Skip to content

Add java postgresql todo terraform template#1792

Merged
fangjian0423 merged 13 commits into
Azure:mainfrom
fangjian0423:todo-java-template-add-psql
Apr 28, 2023
Merged

Add java postgresql todo terraform template#1792
fangjian0423 merged 13 commits into
Azure:mainfrom
fangjian0423:todo-java-template-add-psql

Conversation

@fangjian0423

@fangjian0423 fangjian0423 commented Mar 24, 2023

Copy link
Copy Markdown
Contributor

Todo template with a Java API and Azure Database for PostgreSQL - Flexible Server on Azure App Service. Including:

  • Terraform
    • PostgreSQL
    • AppService Java
    • PostgreSQL Passwordless
  • Repoman for java-postgresql
  • Java-postgresql project

@fangjian0423 fangjian0423 added the area/templates Templates, init, scaffold label Mar 24, 2023
@ghost ghost assigned fangjian0423 Mar 24, 2023
jongio
jongio reviewed Mar 28, 2023
View reviewed changes
Comment thread templates/common/.devcontainer/Dockerfile/postgresql/Dockerfile
Comment thread templates/common/.devcontainer/Dockerfile/postgresql/Dockerfile
Comment thread templates/common/infra/terraform/core/database/postgresql/postgresql.tf Outdated
Comment thread templates/common/infra/terraform/core/database/postgresql/postgresql.tf Outdated
Comment thread templates/common/infra/terraform/core/database/postgresql/postgresql_output.tf Outdated
Comment thread templates/common/infra/terraform/core/database/postgresql/postgresql_variables.tf Outdated
HadwaAbdelhalem
HadwaAbdelhalem requested changes Apr 3, 2023
View reviewed changes

@HadwaAbdelhalem HadwaAbdelhalem left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left few comments mostly on the terraform code side.

Comment thread templates/common/infra/terraform/core/database/postgresql/postgresql.tf
Comment thread templates/common/infra/terraform/core/database/postgresql/postgresql.tf Outdated
Comment thread templates/common/infra/terraform/core/database/postgresql/postgresql.tf Outdated
Comment thread ...lates/common/infra/terraform/core/host/appservice/appservicejava/appservicejava_variables.tf Outdated
Comment thread ...lates/common/infra/terraform/core/host/appservice/appservicejava/appservicejava_variables.tf Outdated
Comment thread ...lates/common/infra/terraform/core/host/appservice/appservicejava/appservicejava_variables.tf Outdated
Comment thread ...lates/common/infra/terraform/core/host/appservice/appservicejava/appservicejava_variables.tf Outdated
Comment thread templates/todo/projects/java-postgresql/.repo/terraform/repo.yaml Outdated
Comment thread templates/todo/projects/java-postgresql/.repo/terraform/infra/output.tf Outdated
@fangjian0423 fangjian0423 mentioned this pull request Apr 4, 2023
Closed
@fangjian0423 fangjian0423 requested a review from jongio April 11, 2023 02:30
@fangjian0423

fangjian0423 commented Apr 13, 2023

Copy link
Copy Markdown
Contributor Author

hi @HadwaAbdelhalem , could you please help to look again?

@jongio jongio requested a review from rajeshkamal5050 April 17, 2023 18:56
@fangjian0423

fangjian0423 commented Apr 21, 2023

Copy link
Copy Markdown
Contributor Author

@rajeshkamal5050 could you pls take a look? thanks.

@rajeshkamal5050

rajeshkamal5050 commented Apr 25, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

@v-xuto can you validate, test this template and report back?

@v-xuto

v-xuto commented Apr 25, 2023

Copy link
Copy Markdown
Member

@v-xuto can you validate, test this template and report back?

@rajeshkamal5050 We have completed the test of these 3 templates (todo-java-mongo-aca, todo-java-mongo and todo-java-postgresql-terraform ), no issue found.

@HadwaAbdelhalem

HadwaAbdelhalem commented Apr 25, 2023

Copy link
Copy Markdown
Contributor

Terraform code looks good to me. @fangjian0423 can you run terraform fmt cmd on all your terraform modules to fix the files format

@azure-sdk

azure-sdk commented Apr 26, 2023

Copy link
Copy Markdown
Collaborator

Repoman Generation Results

Repoman pushed changes to remotes for the following projects:

Project: todo-java-mongo-aca

Remote: azure-samples-staging

Branch: pr/1792

You can initialize this project with:

azd init -t Azure-Samples/todo-java-mongo-aca -b pr/1792

View Changes | Compare Changes

Project: todo-java-mongo

Remote: azure-samples-staging

Branch: pr/1792

You can initialize this project with:

azd init -t Azure-Samples/todo-java-mongo -b pr/1792

View Changes | Compare Changes

Project: todo-java-postgresql-terraform

Remote: azure-samples-staging

Branch: pr/1792

You can initialize this project with:

azd init -t Azure-Samples/todo-java-postgresql-terraform -b pr/1792

View Changes | Compare Changes

@fangjian0423

fangjian0423 commented Apr 27, 2023

Copy link
Copy Markdown
Contributor Author

Terraform code looks good to me. @fangjian0423 can you run terraform fmt cmd on all your terraform modules to fix the files format

done @HadwaAbdelhalem , @rajeshkamal5050 looks like everything has been done for this PR. Can we merge it?

This was referenced Apr 27, 2023
Closed
Closed
@jongio

jongio commented Apr 27, 2023

Copy link
Copy Markdown
Member

🚢

@fangjian0423 fangjian0423 merged commit 37b58ed into Azure:main Apr 28, 2023
@rajeshkamal5050 rajeshkamal5050 mentioned this pull request Jul 11, 2023
Closed
@hemarina hemarina mentioned this pull request Jun 30, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jongio jongio jongio approved these changes
@HadwaAbdelhalem HadwaAbdelhalem HadwaAbdelhalem approved these changes
@wbreza wbreza Awaiting requested review from wbreza
@hattan hattan Awaiting requested review from hattan
@rajeshkamal5050 rajeshkamal5050 Awaiting requested review from rajeshkamal5050
@weikanglim weikanglim Awaiting requested review from weikanglim
@ellismg ellismg Awaiting requested review from ellismg
@vhvb1989 vhvb1989 Awaiting requested review from vhvb1989 vhvb1989 is a code owner
@hemarina hemarina Awaiting requested review from hemarina hemarina is a code owner

Assignees

@fangjian0423 fangjian0423

Labels

area/templates Templates, init, scaffold

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@fangjian0423 @rajeshkamal5050 @v-xuto @HadwaAbdelhalem @azure-sdk @jongio