Skip to content
This repository was archived by the owner on Jan 28, 2022. It is now read-only.

Moving build pipeline to use devcontainer#152

Merged
Azadehkhojandi merged 22 commits intoAzure:masterfrom
storey247:ds/f-devcontainerbuild
Feb 18, 2020
Merged

Moving build pipeline to use devcontainer#152
Azadehkhojandi merged 22 commits intoAzure:masterfrom
storey247:ds/f-devcontainerbuild

Conversation

@storey247
Copy link
Contributor

@storey247 storey247 commented Jan 28, 2020 •
edited by stuartleeks
Loading

  • Updated the azure-pipeline.yaml to run the build processes in devcontainer
  • Removed installation steps which are taken care of by the container
  • Fixes issue with gopls dependency path in devcontainer

These changes bring the following benefits:

  • WYSIWYG development, if it works in dev container then it’ll work on build without needing to adapt built scripts
  • container images are cached to speed up builds
  • allows the easy use of KIND for running tests in a container environment on build agents
  • removes dependency graph complexity on build agents as everything runs in docker
  • keeps the existing build strategy, code coverage etc.

@storey247
Copy link
Contributor Author

storey247 commented Jan 29, 2020

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Jan 29, 2020

Azure Pipelines successfully started running 1 pipeline(s).

@storey247 storey247 changed the title WIP: Moving build pipeline to use devcontainer Moving build pipeline to use devcontainer Jan 29, 2020
@Azadehkhojandi
Copy link
Contributor

Azadehkhojandi commented Feb 5, 2020

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Feb 5, 2020

Azure Pipelines successfully started running 1 pipeline(s).

Azadehkhojandi
Azadehkhojandi suggested changes Feb 5, 2020
View reviewed changes
@lawrencegripper lawrencegripper mentioned this pull request Feb 12, 2020
Merged
@Azadehkhojandi
Copy link
Contributor

Azadehkhojandi commented Feb 14, 2020

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Feb 14, 2020

Azure Pipelines successfully started running 1 pipeline(s).

Azadehkhojandi
Azadehkhojandi previously approved these changes Feb 14, 2020
View reviewed changes
Copy link
Contributor

@Azadehkhojandi Azadehkhojandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

Azadehkhojandi
Azadehkhojandi reviewed Feb 14, 2020
View reviewed changes
@Azadehkhojandi Azadehkhojandi self-requested a review February 14, 2020 08:20
@storey247
Copy link
Contributor Author

storey247 commented Feb 14, 2020

The issues should now be fixed and is ready to merge, can you please review again @Azadehkhojandi as I had to push new changes which removed your approval

@stuartleeks
Copy link
Collaborator

stuartleeks commented Feb 17, 2020

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Feb 17, 2020

Azure Pipelines successfully started running 1 pipeline(s).

@stuartleeks stuartleeks mentioned this pull request Feb 17, 2020
Merged
@Azadehkhojandi Azadehkhojandi merged commit 534af7f into Azure:master Feb 18, 2020
@stuartleeks stuartleeks mentioned this pull request Feb 19, 2020
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@Azadehkhojandi Azadehkhojandi Azadehkhojandi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@storey247 @Azadehkhojandi @stuartleeks