notification-hub: tolerate missing gcmCredential in gcm update output#9495
notification-hub: tolerate missing gcmCredential in gcm update output#9495a0x1ab merged 2 commits intoAzure:mainfrom
Conversation
AAZ output shaping no longer requires properties.gcmCredential; return {} when missing to avoid ResourceNotFoundError.
️✔️Azure CLI Extensions Breaking Change Test
|
|
Hi @a0x1ab, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
There was a problem hiding this comment.
Pull request overview
This PR fixes the az notification-hub credential gcm update command to handle cases where the Azure service response omits the properties.gcmCredential field, preventing false ResourceNotFoundError exceptions.
Key Changes:
- Replaced strict selector method
required()with tolerantget()method - Added null/undefined check with empty dictionary fallback to gracefully handle missing credentials
...otification-hub/azext_notification_hub/aaz/latest/notification_hub/credential/gcm/_create.py
Show resolved
Hide resolved
|
[Release] Update index.json for extension [ notification-hub-2.0.0b2 ] : https://dev.azure.com/msazure/One/_build/results?buildId=148252558&view=results |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az notification-hub
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.