Add non-premium disk option for repair VM#8486
Conversation
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| vm repair create | cmd vm repair create added parameter os_disk_type |
|
Hi @Sandido, |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
|
Please fix conflicts |
|
@AllyW , addressed comments, please re-review |
Co-authored-by: Xing Zhou <Zhou.Xing@microsoft.com>
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
|
||
|
|
||
| @pytest.mark.NonPremiumOSDisk | ||
| class WindowsNonPremiumOSDiskRepairVM(LiveScenarioTest): |
There was a problem hiding this comment.
May I ask why do we mark this test as LiveScenarioTest?
There was a problem hiding this comment.
Because these tests do not run against recorded json responses, they are live runs in Azure when I run them and create actual resources that are then cleaned up. That is what LiveScenarioTest does.
There was a problem hiding this comment.
Just out of curiosity, why can't these tests be created as ScenarioTest? Can their responses be recorded?
There was a problem hiding this comment.
@zhoxing-ms They might be able to, but what is the benefit? I think PS has moved to Live Smoke tests these days anyway. Recorded json tests are an old framework.
|
@zhoxing-ms please re-review |
|
[Release] Update index.json for extension [ vm-repair-2.1.0 ] : https://dev.azure.com/msazure/One/_build/results?buildId=117222476&view=results |
This PR adds a new parameter to set the os disk storage account type of the repair vm to be whatever the user wants.
This allows users who have restrictions on creating premium disks in their environments to use the repair vm feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az vm repair create
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.