You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
SQL Login migration CLI backend uses SqlLoginMigration console app, which is stored in SQLVM storage account blob which is not the recommended source to get the console App.
We need to maintain the version files as part of console app and also in the storage account to support upgrades. Want to do away with this approach as this is error prone.
It also adds the support for versioning for aiding in upgrading to latest version when available.
Renames the console app from Logins.Console to Microsoft.SqlServer.Migration.Logins.ConsoleApp.exe to keep the naming convention consistent with all the other NuGet packages.
Local Testing
First time running the cli command
Running the script with the environment containing the old Login.console app.
When local has a version lower than the latest version uploaded in Nuget.org. But the cx doesn't want to upgrade.
When local has a version lower than the latest version uploaded in Nuget.org and cx opts to upgrade.
When local and latest version is the same.
Related command
az datamigration login-migration
General Guidelines
Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.
Hi @Bhavikshah123,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.
Hi @Bhavikshah123, Please write the description of changes which can be perceived by customers into HISTORY.rst. If you want to release a new extension version, please update the version in setup.py as well.
Set azext.isPreview to true in azext_datamigration/azext_metadata.json if not exists
Notes
Stable/preview tag is inherited from last release. If needed, please add stable/preview label to modify it.
Major/minor/patch/pre increment of version number is calculated by pull request code changes automatically. If needed, please add major/minor/patch/pre label to adjust it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
SQL Login migration CLI backend uses SqlLoginMigration console app, which is stored in SQLVM storage account blob which is not the recommended source to get the console App.
We need to maintain the version files as part of console app and also in the storage account to support upgrades. Want to do away with this approach as this is error prone.
Fix
This PR fixes the following
Local Testing
Related command
az datamigration login-migration
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.