Skip to content

[Containerapp] az containerapp env telemetry: add command for CRUD otlp settings#7356

Merged
yanzhudd merged 38 commits intoAzure:mainfrom
michaelkira:private/michdai/addotlpcommands
Mar 21, 2024
Merged

[Containerapp] az containerapp env telemetry: add command for CRUD otlp settings#7356
yanzhudd merged 38 commits intoAzure:mainfrom
michaelkira:private/michdai/addotlpcommands

Conversation

@michaelkira
Copy link
Copy Markdown
Contributor

@michaelkira michaelkira commented Mar 6, 2024


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link
Copy Markdown

azure-client-tools-bot-prd bot commented Mar 6, 2024

⚠️Azure CLI Extensions Breaking Change Test
⚠️containerapp
rule cmd_name rule_message suggest_message
⚠️ 1009 - ParaPropRemove containerapp env telemetry app-insights delete cmd containerapp env telemetry app-insights delete update parameter name: removed property id_part=name
⚠️ 1009 - ParaPropRemove containerapp env telemetry app-insights set cmd containerapp env telemetry app-insights set update parameter name: removed property id_part=name
⚠️ 1001 - CmdAdd containerapp env telemetry app-insights show cmd containerapp env telemetry app-insights show added
⚠️ 1009 - ParaPropRemove containerapp env telemetry data-dog delete cmd containerapp env telemetry data-dog delete update parameter name: removed property id_part=name
⚠️ 1009 - ParaPropRemove containerapp env telemetry data-dog set cmd containerapp env telemetry data-dog set update parameter name: removed property id_part=name
⚠️ 1001 - CmdAdd containerapp env telemetry data-dog show cmd containerapp env telemetry data-dog show added
⚠️ 1011 - SubgroupAdd containerapp env telemetry otlp sub group containerapp env telemetry otlp added

@azure-client-tools-bot-prd
Copy link
Copy Markdown

Hi @michaelkira,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Mar 6, 2024

Containerapp

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 15, 2024

⚠️ Suggestions

Module: containerapp

  • Update version to 1.0.0b1 in setup.py
  • Set azext.isPreview to true in azext_containerapp/azext_metadata.json if not exists

Notes

  • Stable/preview tag is inherited from last release. If needed, please add stable/preview label to modify it.
  • Major/minor/patch/pre increment of version number is calculated by pull request code changes automatically. If needed, please add major/minor/patch/pre label to adjust it.
  • For more info about extension versioning, please refer to Extension version schema

@Greedygre
Copy link
Copy Markdown
Contributor

Greedygre commented Mar 18, 2024

Hi @AllyW @wangzelin007

Can you help to take a look for this? Thanks.
The version of containerapp is 0.3.49, the containerapp extension is existing for a long time and has released multiple versions.
Also, we have set "azext.isPreview": true, in azext_metadata.json:

.

image

@yanzhudd yanzhudd merged commit 6af630c into Azure:main Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants