Skip to content

[containerapp] 'az containerapp service': remove command group altogether per upcoming deprecation#7302

Merged
zhoxing-ms merged 5 commits intoAzure:mainfrom
scrappywyrm:user/bgashirabake/remove-service-cg-code
Feb 22, 2024
Merged

[containerapp] 'az containerapp service': remove command group altogether per upcoming deprecation#7302
zhoxing-ms merged 5 commits intoAzure:mainfrom
scrappywyrm:user/bgashirabake/remove-service-cg-code

Conversation

@scrappywyrm
Copy link
Copy Markdown
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link
Copy Markdown

azure-client-tools-bot-prd bot commented Feb 21, 2024

❌Azure CLI Extensions Breaking Change Test
❌containerapp
rule cmd_name rule_message suggest_message
1012 - SubgroupRemove containerapp service sub group containerapp service removed please confirm sub group containerapp service removed

@azure-client-tools-bot-prd
Copy link
Copy Markdown

Hi @bgashirabake,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Feb 21, 2024

containerapp

@scrappywyrm
Copy link
Copy Markdown
Contributor Author

styling issues persist and they aren't a part of my change

@azclibot
Copy link
Copy Markdown
Collaborator

⚠️ Suggestions

Module: containerapp

  • Update version to 1.0.0b1 in setup.py
  • Set azext.isPreview to true in azext_containerapp/azext_metadata.json

Notes

  • Stable/preview tag is inherited from last release. If needed, please add stable/preview label to modify it.
  • Major/minor/patch/pre increment of version number is calculated by pull request code changes automatically. If needed, please add major/minor/patch/pre label to adjust it.
  • For more info about extension versioning, please refer to Extension version schema

@zhoxing-ms zhoxing-ms merged commit d835e16 into Azure:main Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Assign Auto assign by bot ContainerApp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants