[ContainerApp] Bugfix - Remove pre-existing containers for source to cloud flow #7293
[ContainerApp] Bugfix - Remove pre-existing containers for source to cloud flow #7293wangzelin007 merged 66 commits intoAzure:mainfrom
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
|
Hi @snehapar9, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
| if self.get_argument_max_inactive_revisions() is not None: | ||
| safe_set(self.new_containerapp, "properties", "configuration", "maxInactiveRevisions", value=self.get_argument_max_inactive_revisions()) | ||
|
|
||
| def set_up_containers_for_private_registry_image(self): |
There was a problem hiding this comment.
Nit: please consider renaming "private registry" to "default registry" as it's the wording we're pushing for now (and it is what is used in the UI)
There was a problem hiding this comment.
Thanks Dan! This change is not valid anymore in my latest commits.
|
LGTM, please rerun tests relate to |
|
Can you help to review and merge this PR when you have chance? Thanks. |
Known issue, @wangzelin007 has sent an email to |
|
Can you help to merge this PR? Thanks. Hope the Credential Scan not block this. |
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| - | Microsoft Azure Storage Account Key | e14a0ec | src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_patch_list_and_apply_with_python310_e2e.yaml | View secret | |
| - | Microsoft Azure Storage Account Key | e14a0ec | src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_get_customdomainverificationid_e2e.yaml | View secret | |
| - | Microsoft Azure Storage Account Key | e14a0ec | src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_get_customdomainverificationid_e2e.yaml | View secret | |
| - | Microsoft Azure Storage Account Key | e14a0ec | src/containerapp/azext_containerapp/tests/latest/recordings/test_containerappjob_create_with_environment_id.yaml | View secret | |
| - | Microsoft Azure Storage Account Key | e14a0ec | src/containerapp/azext_containerapp/tests/latest/recordings/test_containerappjob_create_with_environment_id.yaml | View secret | |
| - | Microsoft Azure Storage Account Key | e14a0ec | src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_up_image_e2e.yaml | View secret | |
| - | Microsoft Azure Storage Account Key | e14a0ec | src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_up_image_e2e.yaml | View secret | |
| - | Microsoft Azure Storage Account Key | e14a0ec | src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_storage.yaml | View secret | |
| - | Microsoft Azure Storage Account Key | e14a0ec | src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_patch_list_and_apply_with_node18_e2e.yaml | View secret | |
| - | Microsoft Azure Storage Account Key | e14a0ec | src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_identity_system.yaml | View secret | |
| - | Microsoft Azure Storage Account Key | e14a0ec | src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_identity_system.yaml | View secret | |
| - | Microsoft Azure Storage Account Key | e14a0ec | src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_preview_create_with_environment_id.yaml | View secret | |
| - | Microsoft Azure Storage Account Key | e14a0ec | src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_preview_create_with_environment_id.yaml | View secret | |
| - | Microsoft Azure Storage Account Key | e14a0ec | src/containerapp/azext_containerapp/tests/latest/recordings/test_containerappjob_create_with_yaml.yaml | View secret | |
| - | Microsoft Azure Storage Account Key | e14a0ec | src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_e2e.yaml | View secret | |
| - | Microsoft Azure Storage Account Key | e14a0ec | src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_e2e.yaml | View secret | |
| - | Microsoft Azure Storage Account Key | e14a0ec | src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_e2e.yaml | View secret | |
| - | Microsoft Azure Storage Account Key | e14a0ec | src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_mtls.yaml | View secret | |
| - | Microsoft Azure Storage Account Key | e14a0ec | src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_up_source_with_bookworm_buildpack_e2e.yaml | View secret | |
| - | Microsoft Azure Storage Account Key | e14a0ec | src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_up_source_with_bookworm_buildpack_e2e.yaml | View secret | |
| - | Microsoft Azure Storage Account Key | e14a0ec | src/containerapp/azext_containerapp/tests/latest/recordings/test_containerappjob_create_with_yaml.yaml | View secret | |
| - | Microsoft Azure Storage Account Key | e14a0ec | src/containerapp/azext_containerapp/tests/latest/recordings/test_containerappjob_create_with_yaml.yaml | View secret | |
| - | Microsoft Azure Storage Account Key | e14a0ec | src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_create_with_vnet_yaml.yaml | View secret | |
| - | Microsoft Azure Storage Account Key | e14a0ec | src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_create_with_vnet_yaml.yaml | View secret | |
| - | Microsoft Azure Storage Account Key | e14a0ec | src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_patch_list_and_apply_with_node18_e2e.yaml | View secret | |
| - | Microsoft Azure Storage Account Key | e14a0ec | src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_patch_list_and_apply_with_node18_e2e.yaml | View secret | |
| - | Microsoft Azure Storage Account Key | e14a0ec | src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_certificate_e2e.yaml | View secret | |
| - | Microsoft Azure Storage Account Key | e14a0ec | src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_java_component.yaml | View secret | |
| - | Microsoft Azure Storage Account Key | e14a0ec | src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_java_component.yaml | View secret | |
| - | Microsoft Azure Storage Account Key | e14a0ec | src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_patch_list_and_apply_with_show_all_e2e.yaml | View secret | |
| - | Microsoft Azure Storage Account Key | e14a0ec | src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_patch_list_and_apply_with_show_all_e2e.yaml | View secret | |
| - | Microsoft Azure Storage Account Key | e14a0ec | src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_up_source_with_dockerfile_e2e.yaml | View secret | |
| - | Microsoft Azure Storage Account Key | e14a0ec | src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_up_source_with_dockerfile_e2e.yaml | View secret | |
| - | Microsoft Azure Storage Account Key | e14a0ec | src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_up_source_with_bullseye_buildpack_e2e.yaml | View secret | |
| - | Microsoft Azure Storage Account Key | e14a0ec | src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_resiliency.yaml | View secret | |
| - | Microsoft Azure Storage Account Key | e14a0ec | src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_resiliency.yaml | View secret | |
| - | Microsoft Azure Storage Account Key | e14a0ec | src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_update_custom_domains.yaml | View secret | |
| - | Microsoft Azure Storage Account Key | e14a0ec | src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_update_custom_domains.yaml | View secret | |
| - | Microsoft Azure Storage Account Key | e14a0ec | src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_custom_domains_e2e.yaml | View secret | |
| - | Microsoft Azure Storage Account Key | e14a0ec | src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_dev_add_on_binding_e2e.yaml | View secret | |
| - | Microsoft Azure Storage Account Key | e14a0ec | src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_resiliency.yaml | View secret | |
| - | Microsoft Azure Storage Account Key | e14a0ec | src/containerapp/azext_containerapp/tests/latest/recordings/test_container_app_mount_secret_e2e.yaml | View secret | |
| - | Microsoft Azure Storage Account Key | e14a0ec | src/containerapp/azext_containerapp/tests/latest/recordings/test_container_app_mount_secret_e2e.yaml | View secret | |
| - | Microsoft Azure Storage Account Key | e14a0ec | src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_up_on_arc_auto_install_extension_e2e.yaml | View secret | |
| - | Microsoft Azure Storage Account Key | e14a0ec | src/containerapp/azext_containerapp/tests/latest/recordings/test_dapr_component_resiliency.yaml | View secret | |
| - | Microsoft Azure Storage Account Key | e14a0ec | src/containerapp/azext_containerapp/tests/latest/recordings/test_dapr_component_resiliency.yaml | View secret | |
| - | Microsoft Azure Storage Account Key | e14a0ec | src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_patch_list_and_apply_with_environment_e2e.yaml | View secret | |
| - | Microsoft Azure Storage Account Key | e14a0ec | src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_patch_list_and_apply_with_environment_e2e.yaml | View secret | |
| - | Microsoft Azure Storage Account Key | e14a0ec | src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_patch_list_and_apply_with_python310_e2e.yaml | View secret | |
| - | Microsoft Azure Storage Account Key | e14a0ec | src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_patch_list_and_apply_with_python310_e2e.yaml | View secret | |
| - | Microsoft Azure Storage Account Key | e14a0ec | src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_managed_service_binding_e2e.yaml | View secret | |
| - | Microsoft Azure Storage Account Key | e14a0ec | src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_managed_service_binding_e2e.yaml | View secret | |
| - | Microsoft Azure Storage Account Key | e14a0ec | src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_custom_domains_e2e.yaml | View secret | |
| - | Microsoft Azure Storage Account Key | e14a0ec | src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_custom_domains_e2e.yaml | View secret | |
| - | Microsoft Azure Storage Account Key | e14a0ec | src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_patch_list_and_apply_without_arguments_e2e.yaml | View secret | |
| - | Microsoft Azure Storage Account Key | e14a0ec | src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_up_on_arc_auto_install_extension_e2e.yaml | View secret | |
| - | Microsoft Azure Storage Account Key | e14a0ec | src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_usages.yaml | View secret | |
| - | Microsoft Azure Storage Account Key | e14a0ec | src/containerapp/azext_containerapp/tests/latest/recordings/test_containerappjob_create_with_environment_id.yaml | View secret | |
| - | Microsoft Azure Storage Account Key | e14a0ec | src/containerapp/azext_containerapp/tests/latest/recordings/test_dapr_component_resiliency.yaml | View secret | |
| - | Microsoft Azure Storage Account Key | e14a0ec | src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_java_component.yaml | View secret | |
| - | Microsoft Azure Storage Account Key | e14a0ec | src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_up_source_with_multiple_environments_e2e.yaml | View secret | |
| - | Microsoft Azure Storage Account Key | e14a0ec | src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_up_source_with_multiple_environments_e2e.yaml | View secret | |
| - | Microsoft Azure Storage Account Key | e14a0ec | src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_up_source_with_multiple_environments_e2e.yaml | View secret | |
| - | Microsoft Azure Storage Account Key | e14a0ec | src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_up_source_with_multiple_environments_e2e.yaml | View secret | |
| - | Microsoft Azure Storage Account Key | e14a0ec | src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_patch_list_and_apply_with_environment_e2e.yaml | View secret | |
| - | Microsoft Azure Storage Account Key | e14a0ec | src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_custom_domains.yaml | View secret | |
| - | Microsoft Azure Storage Account Key | e14a0ec | src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_up_image_e2e.yaml | View secret | |
| - | Microsoft Azure Storage Account Key | e14a0ec | src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_up_source_with_default_registry_image.yaml | View secret | |
| - | Microsoft Azure Storage Account Key | e14a0ec | src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_update_custom_domains.yaml | View secret | |
| - | Microsoft Azure Storage Account Key | e14a0ec | src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_patch_list_and_apply_with_resource_group_e2e.yaml | View secret | |
| - | Microsoft Azure Storage Account Key | e14a0ec | src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_patch_list_and_apply_with_resource_group_e2e.yaml | View secret | |
| - | Microsoft Azure Storage Account Key | e14a0ec | src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_custom_domains.yaml | View secret | |
| - | Microsoft Azure Storage Account Key | e14a0ec | src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_custom_domains.yaml | View secret | |
| - | Microsoft Azure Storage Account Key | e14a0ec | src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_custom_domains.yaml | View secret | |
| - | Microsoft Azure Storage Account Key | e14a0ec | src/containerapp/azext_containerapp/tests/latest/recordings/test_container_app_mount_secret_update_e2e.yaml | View secret | |
| - | Microsoft Azure Storage Account Key | e14a0ec | src/containerapp/azext_containerapp/tests/latest/recordings/test_container_app_mount_secret_update_e2e.yaml | View secret | |
| - | Microsoft Azure Storage Account Key | e14a0ec | src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_patch_list_and_apply_with_show_all_e2e.yaml | View secret | |
| - | Microsoft Azure Storage Account Key | e14a0ec | src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_dev_service_binding_e2e.yaml | View secret | |
| - | Microsoft Azure Storage Account Key | e14a0ec | src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_dev_service_binding_e2e.yaml | View secret | |
| - | Microsoft Azure Storage Account Key | e14a0ec | src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_patch_list_and_apply_with_resource_group_e2e.yaml | View secret |
and 58 others.
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
fd5d95f to
e14a0ec
Compare
|
Can you help to review and merge this PR? I have remove all secrets in the yaml file, but the GitGuardian Security Checks is still failed. These secrets are always existing before, and they are deleted and out of date. Thanks for your help. |
Please fix the Integration Tests first, I can help bypass other security checks. |

This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.