Adding the cli command option for --pod-ip-allocation-mode for cluster creation and nodepool addition in AKS by nairashu · Pull Request #7288 · Azure/azure-cli-extensions

nairashu · 2024-02-14T01:06:26Z

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az aks create -g MyResourceGroup -n MyManagedCluster --os-sku Ubuntu --max-pods MaxPodsPerNode --network-plugin azure --vnet-subnet-id /subscriptions/00000/resourceGroups/AnotherResourceGroup/providers/Microsoft.Network/virtualNetworks/MyVnet/subnets/NodeSubnet --pod-subnet-id /subscriptions/00000/resourceGroups/AnotherResourceGroup/providers/Microsoft.Network/virtualNetworks/MyVnet/subnets/PodSubnet --pod-ip-allocation-mode StaticBlock

General Guidelines

Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
My extension version conforms to the Extension version schema

For new extensions:

My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

azure-client-tools-bot-prd · 2024-02-14T01:06:28Z

❌Azure CLI Extensions Breaking Change Test

❌aks-preview

rule cmd_name rule_message suggest_message

❌ 1010 - ParaPropUpdate aks nodepool add cmd aks nodepool add update parameter spot_max_price: updated property default from nan to nan please change property default from nan to nan for parameter spot_max_price of cmd aks nodepool add

⚠️ 1006 - ParaAdd aks create cmd aks create added parameter pod_ip_allocation_mode

⚠️ 1006 - ParaAdd aks nodepool add cmd aks nodepool add added parameter pod_ip_allocation_mode

azure-client-tools-bot-prd · 2024-02-14T01:06:32Z

Hi @nairashu,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

yonzhan · 2024-02-14T01:06:38Z

WIP

nairashu · 2024-02-15T23:22:55Z

WIP

Removed the WIP after adding all the changes for this agentpool option.

nairashu · 2024-02-16T00:23:22Z

This PR is a placeholder and waiting on this property to get released in the SDK. Requesting early feedback.

src/aks-preview/azext_aks_preview/agentpool_decorator.py

src/aks-preview/azext_aks_preview/_validators.py

FumingZhang

Please add some unit test cases (see examples in test_agentpool_decorator.py) and at least one live test case (see examples in test_aks_commands.py) for the newly added option.

src/aks-preview/azext_aks_preview/_validators.py

src/aks-preview/azext_aks_preview/managed_cluster_decorator.py

FumingZhang

Please resolve merge conflicts

nairashu · 2024-02-21T07:21:55Z

Please add some unit test cases (see examples in test_agentpool_decorator.py) and at least one live test case (see examples in test_aks_commands.py) for the newly added option.

I have added the requested UT and live test case.

FumingZhang

Please fix failed UT

FAILED src/aks-preview/azext_aks_preview/tests/latest/test_agentpool_decorator.py::AKSPreviewAgentPoolContextStandaloneModeTestCase::test_get_pod_ip_allocation_mode
FAILED src/aks-preview/azext_aks_preview/tests/latest/test_agentpool_decorator.py::AKSPreviewAgentPoolContextManagedClusterModeTestCase::test_get_pod_ip_allocation_mode

src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py

nairashu · 2024-02-21T17:08:08Z

Please resolve merge conflicts

Merge conflicts were resolved

yonzhan · 2024-02-21T23:38:01Z

Please fix CI issues

azclibot · 2024-02-22T03:13:54Z

⚠️ Suggestions

Module: aks-preview

Update version to 1.0.0b7 in setup.py
Set azext.isPreview to true in azext_aks-preview/azext_metadata.json

Notes

Stable/preview tag is inherited from last release. If needed, please add stable/preview label to modify it.
Major/minor/patch/pre increment of version number is calculated by pull request code changes automatically. If needed, please add major/minor/patch/pre label to adjust it.
For more info about extension versioning, please refer to Extension version schema

src/aks-preview/azext_aks_preview/agentpool_decorator.py

src/aks-preview/azext_aks_preview/tests/latest/test_agentpool_decorator.py

src/aks-preview/azext_aks_preview/agentpool_decorator.py

…rk profile which was what was failing the CI

…entpool to both the create and update methods

…he get method for the pod-ip-allocation-mode property and also removed the definition and call to set the property in the AgentPoolUpdateDecorator as the property option is only available in the aks create and aks nodepool add commands.

… property in the next version

…tion

src/aks-preview/azext_aks_preview/_help.py

…ted change Co-authored-by: Xing Zhou <Zhou.Xing@microsoft.com>

… voice. Co-authored-by: Xing Zhou <Zhou.Xing@microsoft.com>

azclibot · 2024-02-29T07:21:56Z

[Release] Update index.json for extension [ aks-preview ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=135128&view=results

nairashu requested review from FumingZhang and andyliuliming as code owners February 14, 2024 01:06

azure-client-tools-bot-prd bot added this to the February 2024 (2024-03-05) milestone Feb 14, 2024

microsoft-github-policy-service bot requested review from yanzhudd, yonzhan and zhoxing-ms February 14, 2024 01:06

microsoft-github-policy-service bot assigned yanzhudd and zhoxing-ms Feb 14, 2024

microsoft-github-policy-service bot added Auto-Assign Auto assign by bot AKS labels Feb 14, 2024

nairashu changed the title ~~[WIP]: Adding the cli command option for --pod-ip-allocation-mode for cluster creation and nodepool addition in AKS~~ Adding the cli command option for --pod-ip-allocation-mode for cluster creation and nodepool addition in AKS Feb 15, 2024

tyler-lloyd reviewed Feb 16, 2024

View reviewed changes

src/aks-preview/azext_aks_preview/agentpool_decorator.py Outdated Show resolved Hide resolved

tyler-lloyd reviewed Feb 16, 2024

View reviewed changes

src/aks-preview/azext_aks_preview/_validators.py Outdated Show resolved Hide resolved

tyler-lloyd reviewed Feb 16, 2024

View reviewed changes

src/aks-preview/azext_aks_preview/_validators.py Outdated Show resolved Hide resolved

FumingZhang reviewed Feb 18, 2024

View reviewed changes

src/aks-preview/azext_aks_preview/_validators.py Outdated Show resolved Hide resolved

src/aks-preview/azext_aks_preview/managed_cluster_decorator.py Outdated Show resolved Hide resolved

FumingZhang reviewed Feb 21, 2024

View reviewed changes

nairashu force-pushed the asn/VScale/CliChanges branch from 39f780e to 65d3140 Compare February 21, 2024 07:30

FumingZhang reviewed Feb 21, 2024

View reviewed changes

src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py Outdated Show resolved Hide resolved

src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py Outdated Show resolved Hide resolved

AllyW added the auto-cal-version label Feb 22, 2024

nairashu force-pushed the asn/VScale/CliChanges branch from 5fd6f76 to a2a4cf4 Compare February 22, 2024 16:39

FumingZhang reviewed Feb 26, 2024

View reviewed changes

Ashish Nair added 20 commits February 29, 2024 04:01

Fixed param list

da0e473

Adding the live only tag for the live test added

4d6de3f

Fixed the missing '-' from the max-pods argument

6882dfd

Attempting to fix the resource ID for the node subnet

3ad89a1

Attempting to fix the resource ID for the node subnet

24a52a2

Fixed the property name of the agentpoolprofile

5953766

Updated the expected value for podSubnetID

4cad504

Added the logic to add the podIPAllocationMode to the agentpool netwo…

88ff1e1

…rk profile which was what was failing the CI

Removed the reference to agentpool network profile

0c1276b

Added a test case for managed_cluster properties generation

256a1bf

Added methods to update the pod ip allocation mode property of the ag…

83bc419

…entpool to both the create and update methods

Fixing the variable name in the live test aks_name

15ebd05

Added the live test recording to the PR

3035ee2

Updated the test cases based on the suggestions made in the PR review

c587768

Upated the History and setup.py files after rebasing to merge the new…

30feb66

… property in the next version

Fixed the assertion value

c50184d

Fixed the azdev styles issue

3572460

Removed the liveonly tag

b1e48ee

Excluding the test from the live test as it requires feature registra…

d519a51

…tion

nairashu force-pushed the asn/VScale/CliChanges branch from 7f510d6 to d519a51 Compare February 29, 2024 04:01

zhoxing-ms reviewed Feb 29, 2024

View reviewed changes

src/aks-preview/azext_aks_preview/_help.py Outdated Show resolved Hide resolved

zhoxing-ms reviewed Feb 29, 2024

View reviewed changes

src/aks-preview/azext_aks_preview/_help.py Outdated Show resolved Hide resolved

nairashu and others added 2 commits February 28, 2024 20:09

Update src/aks-preview/azext_aks_preview/_help.py based on the sugges…

1703660

…ted change Co-authored-by: Xing Zhou <Zhou.Xing@microsoft.com>

Update src/aks-preview/azext_aks_preview/_help.py to use first-person…

39ad6cb

… voice. Co-authored-by: Xing Zhou <Zhou.Xing@microsoft.com>

zhoxing-ms approved these changes Feb 29, 2024

View reviewed changes

wangzelin007 approved these changes Feb 29, 2024

View reviewed changes

wangzelin007 merged commit c4eaa7d into Azure:main Feb 29, 2024

nairashu mentioned this pull request May 23, 2025

[AKS] az aks create and az aks nodepool add: Add --pod-ip-allocation-mode to the agentpool profile in AKS for Azure CNI Static Block GA feature support Azure/azure-cli#31544

Merged

3 tasks

Conversation

nairashu commented Feb 14, 2024

Related command

General Guidelines

About Extension Publish

Uh oh!

azure-client-tools-bot-prd bot commented Feb 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

azure-client-tools-bot-prd bot commented Feb 14, 2024

Uh oh!

yonzhan commented Feb 14, 2024

Uh oh!

nairashu commented Feb 15, 2024

Uh oh!

nairashu commented Feb 16, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

FumingZhang left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

FumingZhang left a comment

Choose a reason for hiding this comment

Uh oh!

nairashu commented Feb 21, 2024

Uh oh!

FumingZhang left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

nairashu commented Feb 21, 2024

Uh oh!

yonzhan commented Feb 21, 2024

Uh oh!

azclibot commented Feb 22, 2024

⚠️ Suggestions

Module: aks-preview

Notes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

azclibot commented Feb 29, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

azure-client-tools-bot-prd bot commented Feb 14, 2024 •

edited

Loading