Skip to content

fix connectedk8s proxy test#7286

Merged
wangzelin007 merged 1 commit intoAzure:mainfrom
TheOnlyWei:connectedk8s-fix-proxy-test
Feb 29, 2024
Merged

fix connectedk8s proxy test#7286
wangzelin007 merged 1 commit intoAzure:mainfrom
TheOnlyWei:connectedk8s-fix-proxy-test

Conversation

@TheOnlyWei
Copy link
Copy Markdown
Contributor

@TheOnlyWei TheOnlyWei commented Feb 13, 2024

This PR does the following:

  • Fix proxy live test.
  • Fix unused variable and parameter.
  • Use makedirs instead of mkdir for installing kubectl.

Related command

az connectedk8s

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link
Copy Markdown

azure-client-tools-bot-prd bot commented Feb 13, 2024

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Feb 13, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

@azclibot
Copy link
Copy Markdown
Collaborator

⚠️ Suggestions

Module: connectedk8s

  • Update version to 1.6.6 in setup.py

Notes

  • Stable/preview tag is inherited from last release. If needed, please add stable/preview label to modify it.
  • Major/minor/patch/pre increment of version number is calculated by pull request code changes automatically. If needed, please add major/minor/patch/pre label to adjust it.
  • For more info about extension versioning, please refer to Extension version schema

@sidiesen
Copy link
Copy Markdown
Contributor

@TheOnlyWei please add a description explaining what exactly this PR is changing/adding

Copy link
Copy Markdown
Contributor

@sidiesen sidiesen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a look at my comments and feel free to make any changes as you deem appropriate. Let me know if you have any questions.

@TheOnlyWei TheOnlyWei force-pushed the connectedk8s-fix-proxy-test branch from 48b1777 to f2c7074 Compare February 27, 2024 20:38
Copy link
Copy Markdown
Contributor

@sidiesen sidiesen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@zhoxing-ms
Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 2 pipeline(s).

@TheOnlyWei
Copy link
Copy Markdown
Contributor Author

Hi @zhoxing-ms looks like Credential Scan failed due to some issues with the pipeline and not my update.

@yonzhan yonzhan requested a review from wangzelin007 February 28, 2024 10:22
@wangzelin007 wangzelin007 merged commit fafbf72 into Azure:main Feb 29, 2024
@azclibot
Copy link
Copy Markdown
Collaborator

[Release] Update index.json for extension [ connectedk8s ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=135060&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants