Skip to content

[cosmosdb-preview] Add support for new api version 2024-02-15-preview#7271

Merged
evelyn-ys merged 72 commits intoAzure:mainfrom
jcarolyn:main
Mar 20, 2024
Merged

[cosmosdb-preview] Add support for new api version 2024-02-15-preview#7271
evelyn-ys merged 72 commits intoAzure:mainfrom
jcarolyn:main

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Feb 8, 2024 •
edited by ghost
Loading

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link
Copy Markdown

azure-client-tools-bot-prd bot commented Feb 8, 2024 •
edited
Loading

❌Azure CLI Extensions Breaking Change Test
❌cosmosdb-preview
rule cmd_name rule_message suggest_message
❌ 1007 - ParaRemove cosmosdb create cmd cosmosdb create removed parameter enable_public_network please add back parameter enable_public_network for cmd cosmosdb create
❌ 1007 - ParaRemove cosmosdb restore cmd cosmosdb restore removed parameter enable_public_network please add back parameter enable_public_network for cmd cosmosdb restore
❌ 1007 - ParaRemove cosmosdb update cmd cosmosdb update removed parameter enable_public_network please add back parameter enable_public_network for cmd cosmosdb update
⚠️ 1001 - CmdAdd cosmosdb copy complete cmd cosmosdb copy complete added
⚠️ 1006 - ParaAdd cosmosdb copy create cmd cosmosdb copy create added parameter mode
⚠️ 1006 - ParaAdd cosmosdb create cmd cosmosdb create added parameter enable_partition_merge
⚠️ 1006 - ParaAdd cosmosdb create cmd cosmosdb create added parameter enable_prpp_autoscale
⚠️ 1006 - ParaAdd cosmosdb create cmd cosmosdb create added parameter public_network_access
⚠️ 1006 - ParaAdd cosmosdb gremlin database restore cmd cosmosdb gremlin database restore added parameter disable_ttl
⚠️ 1009 - ParaPropRemove cosmosdb gremlin database restore cmd cosmosdb gremlin database restore update parameter restore_timestamp: removed property required=True
⚠️ 1006 - ParaAdd cosmosdb gremlin graph restore cmd cosmosdb gremlin graph restore added parameter disable_ttl
⚠️ 1009 - ParaPropRemove cosmosdb gremlin graph restore cmd cosmosdb gremlin graph restore update parameter restore_timestamp: removed property required=True
⚠️ 1006 - ParaAdd cosmosdb mongodb collection restore cmd cosmosdb mongodb collection restore added parameter disable_ttl
⚠️ 1009 - ParaPropRemove cosmosdb mongodb collection restore cmd cosmosdb mongodb collection restore update parameter restore_timestamp: removed property required=True
⚠️ 1006 - ParaAdd cosmosdb mongodb database restore cmd cosmosdb mongodb database restore added parameter disable_ttl
⚠️ 1009 - ParaPropRemove cosmosdb mongodb database restore cmd cosmosdb mongodb database restore update parameter restore_timestamp: removed property required=True
⚠️ 1006 - ParaAdd cosmosdb restore cmd cosmosdb restore added parameter disable_ttl
⚠️ 1006 - ParaAdd cosmosdb restore cmd cosmosdb restore added parameter public_network_access
⚠️ 1006 - ParaAdd cosmosdb sql container restore cmd cosmosdb sql container restore added parameter disable_ttl
⚠️ 1009 - ParaPropRemove cosmosdb sql container restore cmd cosmosdb sql container restore update parameter restore_timestamp: removed property required=True
⚠️ 1006 - ParaAdd cosmosdb sql database restore cmd cosmosdb sql database restore added parameter disable_ttl
⚠️ 1009 - ParaPropRemove cosmosdb sql database restore cmd cosmosdb sql database restore update parameter restore_timestamp: removed property required=True
⚠️ 1006 - ParaAdd cosmosdb table restore cmd cosmosdb table restore added parameter disable_ttl
⚠️ 1009 - ParaPropRemove cosmosdb table restore cmd cosmosdb table restore update parameter restore_timestamp: removed property required=True
⚠️ 1006 - ParaAdd cosmosdb update cmd cosmosdb update added parameter enable_partition_merge
⚠️ 1006 - ParaAdd cosmosdb update cmd cosmosdb update added parameter enable_prpp_autoscale
⚠️ 1006 - ParaAdd cosmosdb update cmd cosmosdb update added parameter public_network_access
⚠️ 1008 - ParaPropAdd managed-cassandra cluster deallocate cmd managed-cassandra cluster deallocate update parameter force: added property default=false

@azure-client-tools-bot-prd
Copy link
Copy Markdown

azure-client-tools-bot-prd bot commented Feb 8, 2024

Hi @carjackson-msft,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Feb 8, 2024

cosmosdb-preview

Carolyn Jackson and others added 18 commits February 14, 2024 13:47
update sdk
b7ccf0a
@kushalwarke1
cli changes for PRPP
c54e806
@kushalwarke1
variable name fix, added test case
53b0ab3
@niteshvijay-ms
Add mode in copy job
374e7f7 
(cherry picked from commit a28144517ad4022098561e83d8607c93933dd36c)
@niteshvijay-ms
Add complete job API
f9e78fc 
(cherry picked from commit 3d721cb)
(cherry picked from commit f4e6f01f99eb1299e8c536423f074e9832b71e16)
@niteshvijay-ms
Add test
1a61375
@kushalwarke1
history.rst changes
ca8f496
Merge pull request #2 from carjackson-msft/users/kushalwarke1/prpp-au…
c873cf5 
…toscale

cli changes for PRPP
@niteshvijay-ms
Add history
32d29a6
@niteshvijay1995
Merge branch 'main' into online-container-copy
bd63d86
@niteshvijay1995
Merge pull request #3 from carjackson-msft/online-container-copy
a1140ef 
Online container copy
@minhokang242
Introduce disable_ttl parameter
df53a19
@minhokang242
Syntax error fixes
931fdf7
@minhokang242
Update tests
3182044
@minhokang242
Fix syntax error
c4761fe
@minhokang242
Change test location to WestCentralUS where 0201 batch1 is completed,…
7fe0549 
… add remaining asserts, rerecordings
@minhokang242
Update history file
ebfcbed
Merge pull request #1 from carjackson-msft/users/minhokang/restore_wi…
7d4dc54 
…th_ttl_disabled

Introduce disable_ttl parameter
@ghost ghost marked this pull request as ready for review March 7, 2024 18:26
@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Mar 7, 2024

Please fix CI issues

@ghost
Copy link
Copy Markdown
Author

ghost commented Mar 8, 2024

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Mar 8, 2024

Commenter does not have sufficient privileges for PR 7271 in repo Azure/azure-cli-extensions

@ghost
Copy link
Copy Markdown
Author

ghost commented Mar 8, 2024

Hi @yonzhan, can you please help in triggering CLI checks to run? Seems I do not have sufficient privileges.

@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Mar 8, 2024

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Mar 8, 2024

Azure Pipelines successfully started running 2 pipeline(s).

evelyn-ys
evelyn-ys reviewed Mar 8, 2024
View reviewed changes
@evelyn-ys
Copy link
Copy Markdown
Member

evelyn-ys commented Mar 8, 2024

Please fix CI failure on style check

@ghost
Copy link
Copy Markdown
Author

ghost commented Mar 8, 2024 •
edited by ghost
Loading

Please fix CI failure on style check

Hi @evelyn-ys, is the style check required? According to the pipeline "This task does not block the PR merge." I also ran the azdev style check locally and don't see any errors:

image

I took a look at the errors in the pipeline, they seem to be for existing tests/changes. Given this is not a required check, can we disregard?

@evelyn-ys
Copy link
Copy Markdown
Member

evelyn-ys commented Mar 12, 2024

Pls upgrade your local azdev to latest version and run azdev style again. Or you can check the failure details in CI logs

@ghost
Copy link
Copy Markdown
Author

ghost commented Mar 12, 2024

@evelyn-ys style has been fixed.

evelyn-ys
evelyn-ys reviewed Mar 13, 2024
View reviewed changes
evelyn-ys
evelyn-ys requested changes Mar 13, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@evelyn-ys evelyn-ys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the version in HISTORY.rst to align with the version in setup.py

@ghost
Copy link
Copy Markdown
Author

ghost commented Mar 14, 2024

Hi @evelyn-ys, this has been fixed. Can we please merge this?

@evelyn-ys evelyn-ys merged commit 7e7e029 into Azure:main Mar 20, 2024
@azclibot
Copy link
Copy Markdown
Collaborator

azclibot commented Mar 20, 2024

[Release] Update index.json for extension [ cosmosdb-preview ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=140834&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@calvinhzy calvinhzy Awaiting requested review from calvinhzy

@yonzhan yonzhan Awaiting requested review from yonzhan

Assignees

@evelyn-ys evelyn-ys

Labels

Auto-Assign Auto assign by bot CosmosDB

Projects

None yet

Milestone

February 2024 (2024-03-05)

Development

Successfully merging this pull request may close these issues.

9 participants

@yonzhan @evelyn-ys @azclibot @kushalwarke1 @niteshvijay-ms @niteshvijay1995 @minhokang242 @DrewKaufmann @AgarwalVivek