Add parameter to set revision `--revision` for the Azure Service Mesh addon while creating AKS cluster. by deveshdama · Pull Request #7270 · Azure/azure-cli-extensions

deveshdama · 2024-02-07T20:05:27Z

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az aks create -g myResourceGroup -n myCluster --enable-azure-service-mesh --revision asm-1-17

General Guidelines

Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
My extension version conforms to the Extension version schema

For new extensions:

My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

… addon while creating AKS cluster.

azure-client-tools-bot-prd · 2024-02-07T20:05:30Z

⚠️Azure CLI Extensions Breaking Change Test

⚠️aks-preview

rule cmd_name rule_message suggest_message

⚠️ 1006 - ParaAdd aks create cmd aks create added parameter revision

azure-client-tools-bot-prd · 2024-02-07T20:05:33Z

Hi @deveshdama,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

yonzhan · 2024-02-07T20:05:42Z

Thank you for your contribution! We will review the pull request and get back to you soon.

src/aks-preview/azext_aks_preview/tests/latest/test_managed_cluster_decorator.py

FumingZhang

lgtm

It would be great if you could help update one of the existing live test cases to cover the new option.

FumingZhang

lgtm

It would be great if you could help update one of the existing live test cases to cover the new option.

src/aks-preview/HISTORY.rst

src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py

FumingZhang · 2024-02-28T02:35:14Z

Feature owner queued live tests, test passed!

test_aks_azure_service_mesh_with_pluginca
test_aks_azure_service_mesh_enable_disable
test_aks_azure_service_mesh_with_ingress_gateway
test_aks_azure_service_mesh_with_egress_gateway
test_aks_azure_service_mesh_get_revisions
test_aks_azure_service_mesh_get_upgrades

FumingZhang

LGTM

src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py

…ds.py

zhoxing-ms · 2024-02-29T04:04:44Z

@wangzelin007 Could you please bypass the CI issue?

gitguardian · 2024-02-29T07:22:15Z

⚠️ GitGuardian has uncovered 94 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request

GitGuardian id	Secret	Commit	Filename
-	Microsoft Azure Storage Account Key	`1705364`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_patch_list_and_apply_with_python310_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`1705364`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_get_customdomainverificationid_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`1705364`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_get_customdomainverificationid_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`1705364`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_up_image_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`1705364`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_up_image_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`1705364`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_storage.yaml	View secret
-	Microsoft Azure Storage Account Key	`1705364`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_patch_list_and_apply_with_node18_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`1705364`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_identity_system.yaml	View secret
-	Microsoft Azure Storage Account Key	`1705364`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_identity_system.yaml	View secret
-	Microsoft Azure Storage Account Key	`1705364`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_preview_create_with_environment_id.yaml	View secret
-	Microsoft Azure Storage Account Key	`1705364`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_preview_create_with_environment_id.yaml	View secret
-	Microsoft Azure Storage Account Key	`1705364`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`1705364`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`1705364`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`1705364`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_mtls.yaml	View secret
-	Microsoft Azure Storage Account Key	`1705364`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_create_with_vnet_yaml.yaml	View secret
-	Microsoft Azure Storage Account Key	`1705364`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_create_with_vnet_yaml.yaml	View secret
-	Microsoft Azure Storage Account Key	`1705364`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_patch_list_and_apply_with_node18_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`1705364`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_patch_list_and_apply_with_node18_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`1705364`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_certificate_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`1705364`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_patch_list_and_apply_with_show_all_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`1705364`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_patch_list_and_apply_with_show_all_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`1705364`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_resiliency.yaml	View secret
-	Microsoft Azure Storage Account Key	`1705364`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_resiliency.yaml	View secret
-	Microsoft Azure Storage Account Key	`1705364`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_update_custom_domains.yaml	View secret
-	Microsoft Azure Storage Account Key	`1705364`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_update_custom_domains.yaml	View secret
-	Microsoft Azure Storage Account Key	`1705364`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_custom_domains_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`1705364`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_resiliency.yaml	View secret
-	Microsoft Azure Storage Account Key	`1705364`	src/containerapp/azext_containerapp/tests/latest/recordings/test_container_app_mount_secret_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`1705364`	src/containerapp/azext_containerapp/tests/latest/recordings/test_container_app_mount_secret_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`1705364`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_patch_list_and_apply_with_environment_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`1705364`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_patch_list_and_apply_with_environment_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`1705364`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_patch_list_and_apply_with_python310_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`1705364`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_patch_list_and_apply_with_python310_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`1705364`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_custom_domains_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`1705364`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_custom_domains_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`1705364`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_patch_list_and_apply_without_arguments_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`1705364`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_usages.yaml	View secret
-	Microsoft Azure Storage Account Key	`1705364`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_patch_list_and_apply_with_environment_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`1705364`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_custom_domains.yaml	View secret
-	Microsoft Azure Storage Account Key	`1705364`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_up_image_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`1705364`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_update_custom_domains.yaml	View secret
-	Microsoft Azure Storage Account Key	`1705364`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_patch_list_and_apply_with_resource_group_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`1705364`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_patch_list_and_apply_with_resource_group_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`1705364`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_custom_domains.yaml	View secret
-	Microsoft Azure Storage Account Key	`1705364`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_custom_domains.yaml	View secret
-	Microsoft Azure Storage Account Key	`1705364`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_custom_domains.yaml	View secret
-	Microsoft Azure Storage Account Key	`1705364`	src/containerapp/azext_containerapp/tests/latest/recordings/test_container_app_mount_secret_update_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`1705364`	src/containerapp/azext_containerapp/tests/latest/recordings/test_container_app_mount_secret_update_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`1705364`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_patch_list_and_apply_with_show_all_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`1705364`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_patch_list_and_apply_with_resource_group_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`1705364`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_la_dynamic_json.yaml	View secret
-	Microsoft Azure Storage Account Key	`1705364`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_create_with_vnet_yaml.yaml	View secret
-	Microsoft Azure Storage Account Key	`1705364`	src/containerapp/azext_containerapp/tests/latest/recordings/test_container_app_mount_azurefile_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`1705364`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_certificate_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`1705364`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_certificate_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`1705364`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_patch_list_and_apply_without_arguments_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`1705364`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_patch_list_and_apply_without_arguments_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`1705364`	src/containerapp/azext_containerapp/tests/latest/recordings/test_container_app_mount_secret_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`1705364`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_logs_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`1705364`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_logs_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`1705364`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_logs_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`1705364`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_dapr_components.yaml	View secret
-	Microsoft Azure Storage Account Key	`1705364`	src/containerapp/azext_containerapp/tests/latest/recordings/test_container_app_mount_secret_update_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`1705364`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_dapr_components.yaml	View secret
-	Microsoft Azure Storage Account Key	`1705364`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_dapr_components.yaml	View secret
-	Microsoft Azure Storage Account Key	`1705364`	src/containerapp/azext_containerapp/tests/latest/recordings/test_container_app_mount_nfsazurefile_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`1705364`	src/containerapp/azext_containerapp/tests/latest/recordings/test_container_app_mount_nfsazurefile_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`1705364`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_tcp_ingress.yaml	View secret
-	Microsoft Azure Storage Account Key	`1705364`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_storage.yaml	View secret
-	Microsoft Azure Storage Account Key	`1705364`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_storage.yaml	View secret
-	Microsoft Azure Storage Account Key	`1705364`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_preview_create_with_environment_id.yaml	View secret
-	Microsoft Azure Storage Account Key	`1705364`	src/containerapp/azext_containerapp/tests/latest/recordings/test_container_app_mount_azurefile_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`1705364`	src/containerapp/azext_containerapp/tests/latest/recordings/test_container_app_mount_azurefile_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`1705364`	src/containerapp/azext_containerapp/tests/latest/recordings/test_container_app_mount_nfsazurefile_e2e.yaml	View secret
-	Microsoft Azure Storage Account Key	`1705364`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_preview_create_with_environment_id.yaml	View secret
-	Microsoft Azure Storage Account Key	`1705364`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_preview_create_with_environment_id.yaml	View secret
-	Microsoft Azure Storage Account Key	`1705364`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_tcp_ingress.yaml	View secret
-	Microsoft Azure Storage Account Key	`1705364`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_tcp_ingress.yaml	View secret
-	Microsoft Azure Storage Account Key	`1705364`	src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_get_customdomainverificationid_e2e.yaml	View secret

and 14 others.

🛠 Guidelines to remediate hardcoded secrets

Understand the implications of revoking this secret by investigating where it is used in your code.
Replace and store your secrets safely. Learn here the best practices.
Revoke and rotate these secrets.
If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

following these best practices for managing and storing secrets including API keys and other credentials
install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!}

Add parameter to set revision --revision for the Azure Service Mesh…

af6b56b

… addon while creating AKS cluster.

deveshdama requested review from FumingZhang and andyliuliming as code owners February 7, 2024 20:05

azure-client-tools-bot-prd bot added this to the February 2024 (2024-03-05) milestone Feb 7, 2024

microsoft-github-policy-service bot requested a review from zhoxing-ms February 7, 2024 20:05

microsoft-github-policy-service bot requested review from yanzhudd and yonzhan February 7, 2024 20:05

microsoft-github-policy-service bot assigned yanzhudd and zhoxing-ms Feb 7, 2024

microsoft-github-policy-service bot added Auto-Assign Auto assign by bot AKS labels Feb 7, 2024

fix style issues

75b04b9

SanyaKochhar reviewed Feb 8, 2024

View reviewed changes

src/aks-preview/azext_aks_preview/tests/latest/test_managed_cluster_decorator.py Show resolved Hide resolved

deveshdama and others added 2 commits February 8, 2024 16:35

added a unit test case

41a9889

Merge branch 'main' into main

6033249

FumingZhang reviewed Feb 10, 2024

View reviewed changes

deveshdama and others added 4 commits February 21, 2024 00:53

Merge branch 'Azure:main' into main

380e384

dynamically fetch asm supported revision for test cases.

28cef3c

fix azdev style error

6f7d82b

update live test recording files.

de9725f

FumingZhang reviewed Feb 28, 2024

View reviewed changes

src/aks-preview/HISTORY.rst Outdated Show resolved Hide resolved

FumingZhang reviewed Feb 28, 2024

View reviewed changes

src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py Outdated Show resolved Hide resolved

deveshdama and others added 2 commits February 27, 2024 20:49

Merge branch 'Azure:main' into main

508f123

changes as per review comments

937c8c2

FumingZhang approved these changes Feb 28, 2024

View reviewed changes

FumingZhang reviewed Feb 28, 2024

View reviewed changes

src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py Outdated Show resolved Hide resolved

Update src/aks-preview/azext_aks_preview/tests/latest/test_aks_comman…

c446b56

…ds.py

zhoxing-ms approved these changes Feb 29, 2024

View reviewed changes

Merge branch 'main' into main

1705364

wangzelin007 approved these changes Feb 29, 2024

View reviewed changes

wangzelin007 merged commit 141ed26 into Azure:main Feb 29, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add parameter to set revision `--revision` for the Azure Service Mesh addon while creating AKS cluster.#7270

Add parameter to set revision `--revision` for the Azure Service Mesh addon while creating AKS cluster.#7270
wangzelin007 merged 12 commits intoAzure:mainfrom
deveshdama:main

deveshdama commented Feb 7, 2024

Uh oh!

azure-client-tools-bot-prd bot commented Feb 7, 2024 •

edited

Loading

Uh oh!

azure-client-tools-bot-prd bot commented Feb 7, 2024

Uh oh!

yonzhan commented Feb 7, 2024

Uh oh!

Uh oh!

FumingZhang left a comment

Uh oh!

FumingZhang left a comment

Uh oh!

Uh oh!

Uh oh!

FumingZhang commented Feb 28, 2024

Uh oh!

FumingZhang left a comment

Uh oh!

Uh oh!

zhoxing-ms commented Feb 29, 2024

Uh oh!

gitguardian bot commented Feb 29, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

deveshdama commented Feb 7, 2024

Related command

General Guidelines

About Extension Publish

Uh oh!

azure-client-tools-bot-prd bot commented Feb 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

azure-client-tools-bot-prd bot commented Feb 7, 2024

Uh oh!

yonzhan commented Feb 7, 2024

Uh oh!

Uh oh!

FumingZhang left a comment

Choose a reason for hiding this comment

Uh oh!

FumingZhang left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

FumingZhang commented Feb 28, 2024

Uh oh!

FumingZhang left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

zhoxing-ms commented Feb 29, 2024

Uh oh!

gitguardian bot commented Feb 29, 2024

⚠️ GitGuardian has uncovered 94 secrets following the scan of your pull request.

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

azure-client-tools-bot-prd bot commented Feb 7, 2024 •

edited

Loading