Skip to content

[AKS] Replace guardrails with safeguards#7260

Merged
wangzelin007 merged 14 commits intoAzure:mainfrom
NickKeller:nikelle/grdtosfg
Feb 28, 2024
Merged

[AKS] Replace guardrails with safeguards#7260
wangzelin007 merged 14 commits intoAzure:mainfrom
NickKeller:nikelle/grdtosfg

Conversation

@NickKeller
Copy link
Copy Markdown
Member

@NickKeller NickKeller commented Feb 6, 2024

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link
Copy Markdown

azure-client-tools-bot-prd bot commented Feb 6, 2024 •
edited
Loading

❌Azure CLI Extensions Breaking Change Test
❌aks-preview
rule cmd_name rule_message suggest_message
❌ 1007 - ParaRemove aks create cmd aks create removed parameter guardrails_excluded_ns please add back parameter guardrails_excluded_ns for cmd aks create
❌ 1007 - ParaRemove aks create cmd aks create removed parameter guardrails_level please add back parameter guardrails_level for cmd aks create
❌ 1007 - ParaRemove aks create cmd aks create removed parameter guardrails_version please add back parameter guardrails_version for cmd aks create
❌ 1007 - ParaRemove aks update cmd aks update removed parameter guardrails_excluded_ns please add back parameter guardrails_excluded_ns for cmd aks update
❌ 1007 - ParaRemove aks update cmd aks update removed parameter guardrails_level please add back parameter guardrails_level for cmd aks update
❌ 1007 - ParaRemove aks update cmd aks update removed parameter guardrails_version please add back parameter guardrails_version for cmd aks update
⚠️ 1006 - ParaAdd aks create cmd aks create added parameter safeguards_excluded_ns
⚠️ 1006 - ParaAdd aks create cmd aks create added parameter safeguards_level
⚠️ 1006 - ParaAdd aks create cmd aks create added parameter safeguards_version
⚠️ 1006 - ParaAdd aks update cmd aks update added parameter safeguards_excluded_ns
⚠️ 1006 - ParaAdd aks update cmd aks update added parameter safeguards_level
⚠️ 1006 - ParaAdd aks update cmd aks update added parameter safeguards_version

@azure-client-tools-bot-prd
Copy link
Copy Markdown

azure-client-tools-bot-prd bot commented Feb 6, 2024

Hi @NickKeller,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Feb 6, 2024

AKS

FumingZhang
FumingZhang reviewed Feb 7, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally lgtm

qpetraroia
qpetraroia reviewed Feb 7, 2024
View reviewed changes
qpetraroia
qpetraroia reviewed Feb 7, 2024
View reviewed changes
FumingZhang
FumingZhang reviewed Feb 18, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Queued live test to validate the change.

  • test_aks_create_with_safeguards
  • test_aks_update_with_safeguards

@NickKeller
Copy link
Copy Markdown
Member Author

NickKeller commented Feb 20, 2024

Queued live test to validate the change.

Live test passed, and merge conflicts are resovled

FumingZhang
FumingZhang reviewed Feb 21, 2024
View reviewed changes
@qpetraroia
Copy link
Copy Markdown

qpetraroia commented Feb 22, 2024

@FumingZhang is this good to be merged?

FumingZhang
FumingZhang approved these changes Feb 23, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

yanzhudd
yanzhudd reviewed Feb 23, 2024
View reviewed changes
src/aks-preview/HISTORY.rst Outdated
Pending
2.0.0b1
+++++++
* Replace `guardrails` parameters with `safeguards`.
Copy link
Copy Markdown
Contributor

@yanzhudd yanzhudd Feb 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this change is a breaking change, it is better to specify "breaking change" in the history notes, so that users can be easily aware of that.

Copy link
Copy Markdown

@qpetraroia qpetraroia Feb 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yanzhudd, does it matter even if the feature was never released?

Copy link
Copy Markdown
Member Author

@NickKeller NickKeller Feb 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The major version was also increased too, users can see that

@qpetraroia
Copy link
Copy Markdown

qpetraroia commented Feb 23, 2024

If there are no problems, can this please be merged? We are aiming for a kubecon eu release.

FumingZhang
FumingZhang reviewed Feb 26, 2024
View reviewed changes
@wangzelin007 wangzelin007 merged commit 6567c72 into Azure:main Feb 28, 2024
@azclibot
Copy link
Copy Markdown
Collaborator

azclibot commented Feb 28, 2024

[Release] Update index.json for extension [ aks-preview ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=134557&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FumingZhang FumingZhang FumingZhang approved these changes

@yanzhudd yanzhudd yanzhudd left review comments

@wangzelin007 wangzelin007 wangzelin007 approved these changes

@andyliuliming andyliuliming Awaiting requested review from andyliuliming andyliuliming is a code owner

@zhoxing-ms zhoxing-ms Awaiting requested review from zhoxing-ms

@yonzhan yonzhan Awaiting requested review from yonzhan

+1 more reviewer

@qpetraroia qpetraroia qpetraroia left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@zhoxing-ms zhoxing-ms

@yanzhudd yanzhudd

Labels

AKS Auto-Assign Auto assign by bot

Projects

None yet

Milestone

February 2024 (2024-03-05)

Development

Successfully merging this pull request may close these issues.

8 participants

@NickKeller @yonzhan @qpetraroia @azclibot @wangzelin007 @FumingZhang @yanzhudd @zhoxing-ms