Skip to content

[Containerapp] az containerapp service: Fix deprecate version#7236

Merged
wangzelin007 merged 3 commits intoAzure:mainfrom
Greedygre:xnyu/20240201_fix_test_for_dev
Feb 1, 2024
Merged

[Containerapp] az containerapp service: Fix deprecate version#7236
wangzelin007 merged 3 commits intoAzure:mainfrom
Greedygre:xnyu/20240201_fix_test_for_dev

Conversation

@Greedygre
Copy link
Copy Markdown
Contributor

@Greedygre Greedygre commented Feb 1, 2024 •
edited
Loading

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

The old deprecate version is too close to remove the related commands, so the CI linter failed as following, we need to set the version to a bigger one, to give the buffer time to remove the old command in the next extension version:

-  FAIL - HIGH severity: expired_command_group
    Command-Group: `containerapp service kafka` - Deprecated command group is expired and should be removed.
    Command-Group: `containerapp service mariadb` - Deprecated command group is expired and should be removed.
    Command-Group: `containerapp service postgres` - Deprecated command group is expired and should be removed.
    Command-Group: `containerapp service qdrant` - Deprecated command group is expired and should be removed.
    Command-Group: `containerapp service redis` - Deprecated command group is expired and should be removed.
    Command-Group: `containerapp service` - Deprecated command group is expired and should be removed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link
Copy Markdown

azure-client-tools-bot-prd bot commented Feb 1, 2024 •
edited
Loading

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd
Copy link
Copy Markdown

azure-client-tools-bot-prd bot commented Feb 1, 2024

Hi @Greedygre,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@azure-client-tools-bot-prd
Copy link
Copy Markdown

azure-client-tools-bot-prd bot commented Feb 1, 2024

Hi @Greedygre,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Feb 1, 2024

Containerapp

@microsoft-github-policy-service microsoft-github-policy-service bot added the Auto-Assign Auto assign by bot label Feb 1, 2024
Juliehzl
Juliehzl reviewed Feb 1, 2024
View reviewed changes
Juliehzl
Juliehzl reviewed Feb 1, 2024
View reviewed changes
Juliehzl
Juliehzl reviewed Feb 1, 2024
View reviewed changes
@Greedygre Greedygre mentioned this pull request Feb 1, 2024
Merged
4 tasks
@wangzelin007 wangzelin007 merged commit a21db49 into Azure:main Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wangzelin007 wangzelin007 wangzelin007 approved these changes

@Juliehzl Juliehzl Juliehzl approved these changes

@yonzhan yonzhan Awaiting requested review from yonzhan

@yanzhudd yanzhudd Awaiting requested review from yanzhudd

@zhoxing-ms zhoxing-ms Awaiting requested review from zhoxing-ms

@jsntcy jsntcy Awaiting requested review from jsntcy

@ruslany ruslany Awaiting requested review from ruslany

@sanchitmehta sanchitmehta Awaiting requested review from sanchitmehta

@ebencarek ebencarek Awaiting requested review from ebencarek

@JennyLawrance JennyLawrance Awaiting requested review from JennyLawrance

@howang-ms howang-ms Awaiting requested review from howang-ms howang-ms is a code owner

@vinisoto vinisoto Awaiting requested review from vinisoto

@chinadragon0515 chinadragon0515 Awaiting requested review from chinadragon0515

@vturecek vturecek Awaiting requested review from vturecek

@torosent torosent Awaiting requested review from torosent

@pagariyaalok pagariyaalok Awaiting requested review from pagariyaalok

@jijohn14 jijohn14 Awaiting requested review from jijohn14

+1 more reviewer

@scrappywyrm scrappywyrm scrappywyrm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@zhoxing-ms zhoxing-ms

Labels

Auto-Assign Auto assign by bot ContainerApp

Projects

None yet

Milestone

February 2024 (2024-03-05)

Development

Successfully merging this pull request may close these issues.

6 participants

@Greedygre @yonzhan @wangzelin007 @Juliehzl @scrappywyrm @zhoxing-ms