[Containerapp] 'az containerapp env create': Support --mi-system-assigned and --mi-user-assigned, support 'az containerapp env identity assign/remove/show' by njuCZ · Pull Request #7226 · Azure/azure-cli-extensions

njuCZ · 2024-01-30T05:40:27Z

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
My extension version conforms to the Extension version schema

For new extensions:

My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

azure-client-tools-bot-prd · 2024-01-30T05:40:30Z

⚠️Azure CLI Extensions Breaking Change Test

⚠️containerapp

rule cmd_name rule_message suggest_message

⚠️ 1006 - ParaAdd containerapp env create cmd containerapp env create added parameter system_assigned

⚠️ 1006 - ParaAdd containerapp env create cmd containerapp env create added parameter user_assigned

⚠️ 1011 - SubgroupAdd containerapp env identity sub group containerapp env identity added

azure-client-tools-bot-prd · 2024-01-30T05:40:33Z

Hi @njuCZ,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

azure-client-tools-bot-prd · 2024-01-30T05:40:36Z

Hi @njuCZ,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

yonzhan · 2024-01-30T05:40:37Z

Thank you for your contribution! We will review the pull request and get back to you soon.

src/containerapp/azext_containerapp/tests/latest/test_containerapp_env_commands.py

src/containerapp/azext_containerapp/_params.py

src/containerapp/azext_containerapp/commands.py

src/containerapp/azext_containerapp/custom.py

Greedygre · 2024-02-01T06:10:59Z

Hi @zhoxing-ms @wangzelin007

The az containerapp service is deprecated from 2.56.1, after azure-cli version 2.57.0 release in dev , the linter failed with following error, can you help to handle it? Thanks.


    Parameter: containerapp service postgres create, `service_name` - Missing help
    Parameter: containerapp service postgres delete, `_subscription` - Missing help
    Parameter: containerapp service postgres delete, `cmd` - Missing help
    Parameter: containerapp service postgres delete, `no_wait` - Missing help
    Parameter: containerapp service postgres delete, `resource_group_name` - Missing help
    Parameter: containerapp service postgres delete, `service_name` - Missing help
    Parameter: containerapp service postgres delete, `yes` - Missing help
    Parameter: containerapp service qdrant create, `_subscription` - Missing help
    Parameter: containerapp service qdrant create, `cmd` - Missing help
    Parameter: containerapp service qdrant create, `disable_warnings` - Missing help
    Parameter: containerapp service qdrant create, `environment_name` - Missing help
    Parameter: containerapp service qdrant create, `no_wait` - Missing help
    Parameter: containerapp service qdrant create, `resource_group_name` - Missing help
    Parameter: containerapp service qdrant create, `service_name` - Missing help
    Parameter: containerapp service qdrant delete, `_subscription` - Missing help
    Parameter: containerapp service qdrant delete, `cmd` - Missing help
    Parameter: containerapp service qdrant delete, `no_wait` - Missing help
    Parameter: containerapp service qdrant delete, `resource_group_name` - Missing help
    Parameter: containerapp service qdrant delete, `service_name` - Missing help
    Parameter: containerapp service qdrant delete, `yes` - Missing help
    Parameter: containerapp service redis create, `_subscription` - Missing help
    Parameter: containerapp service redis create, `cmd` - Missing help
    Parameter: containerapp service redis create, `disable_warnings` - Missing help
    Parameter: containerapp service redis create, `environment_name` - Missing help
    Parameter: containerapp service redis create, `no_wait` - Missing help
    Parameter: containerapp service redis create, `resource_group_name` - Missing help
    Parameter: containerapp service redis create, `service_name` - Missing help
    Parameter: containerapp service redis delete, `_subscription` - Missing help
    Parameter: containerapp service redis delete, `cmd` - Missing help
    Parameter: containerapp service redis delete, `no_wait` - Missing help
    Parameter: containerapp service redis delete, `resource_group_name` - Missing help
    Parameter: containerapp service redis delete, `service_name` - Missing help
    Parameter: containerapp service redis delete, `yes` - Missing help

src/containerapp/azext_containerapp/_help.py

src/containerapp/azext_containerapp/tests/latest/test_containerapp_env_commands.py

src/containerapp/azext_containerapp/_params.py

src/containerapp/azext_containerapp/containerapp_env_decorator.py

src/containerapp/HISTORY.rst

Co-authored-by: Yan Zhu <105691024+yanzhudd@users.noreply.github.com>

azure-client-tools-bot-prd bot added this to the February 2024 (2024-03-05) milestone Jan 30, 2024

yonzhan requested review from yanzhudd and zhoxing-ms January 30, 2024 06:08

yonzhan assigned zhoxing-ms Jan 30, 2024

njuCZ changed the title ~~Support Env Managed Identity~~ [Containerapp] 'az containerapp env create': Support --mi-system-assigned and --mi-user-assigned, support 'az containerapp env identity assign/remove/show' Jan 31, 2024