Enable NFS Azure file Storage for managed environment by LaylaLiu-gmail · Pull Request #7155 · Azure/azure-cli-extensions

LaylaLiu-gmail · 2024-01-05T07:24:16Z

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az containerapp env storage set

General Guidelines

Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)

For new extensions:

My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

azure-client-tools-bot-prd · 2024-01-05T07:24:19Z

⚠️Azure CLI Extensions Breaking Change Test

⚠️containerapp

rule cmd_name rule_message suggest_message

⚠️ 1006 - ParaAdd containerapp env storage set cmd containerapp env storage set added parameter server

⚠️ 1006 - ParaAdd containerapp env storage set cmd containerapp env storage set added parameter storage_type

⚠️ 1009 - ParaPropRemove containerapp env storage set cmd containerapp env storage set update parameter access_mode: removed property required=True

⚠️ 1009 - ParaPropRemove containerapp env storage set cmd containerapp env storage set update parameter azure_file_account_key: removed property required=True

⚠️ 1009 - ParaPropRemove containerapp env storage set cmd containerapp env storage set update parameter azure_file_account_name: removed property required=True

⚠️ 1009 - ParaPropRemove containerapp env storage set cmd containerapp env storage set update parameter azure_file_share_name: removed property required=True

azure-client-tools-bot-prd · 2024-01-05T07:24:22Z

Hi @LaylaLiu-gmail,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

azure-client-tools-bot-prd · 2024-01-05T07:24:25Z

Hi @LaylaLiu-gmail,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

yonzhan · 2024-01-05T07:24:28Z

Thank you for your contribution! We will review the pull request and get back to you soon.

src/containerapp/HISTORY.rst

src/containerapp/azext_containerapp/_clients.py

src/containerapp/azext_containerapp/_help.py

src/containerapp/azext_containerapp/_params.py

src/containerapp/azext_containerapp/containerapp_env_storage_decorator.py

src/containerapp/azext_containerapp/tests/latest/test_containerapp_create_update_with_yaml.py

src/containerapp/azext_containerapp/tests/latest/test_containerapp_nfsazurefile.py

src/containerapp/azext_containerapp/tests/latest/test_containerappjob_with_yaml.py

src/containerapp/azext_containerapp/containerapp_env_storage_decorator.py

azure-client-tools-bot-prd bot added this to the January 2024 (2024-02-06) milestone Jan 5, 2024

microsoft-github-policy-service bot requested review from Greedygre, JennyLawrance, Juliehzl, chinadragon0515, ebencarek, howang-ms, jijohn14, jsntcy, pagariyaalok, ruslany, sanchitmehta, torosent, vinisoto, vturecek, wangzelin007, yanzhudd, yonzhan and zhoxing-ms January 5, 2024 07:24

microsoft-github-policy-service bot added the Auto-Assign Auto assign by bot label Jan 5, 2024

microsoft-github-policy-service bot assigned zhoxing-ms Jan 5, 2024

microsoft-github-policy-service bot added the ContainerApp label Jan 5, 2024

LaylaLiu-gmail force-pushed the user/layliu/Enablenfsazurefile branch from 1f24186 to 62a8a51 Compare January 9, 2024 04:48

Greedygre force-pushed the user/layliu/Enablenfsazurefile branch from d6ed850 to 8eab727 Compare January 15, 2024 08:55