[containerapp] az containerapp env create: Update the default value of --enable-workload-profiles to True#6891
Merged
yanzhudd merged 8 commits intoAzure:mainfrom Oct 25, 2023
Conversation
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| containerapp env create | cmd containerapp env create update parameter enable_workload_profiles: added property default=True |
|
Hi @Greedygre, |
Collaborator
|
containerapp |
Juliehzl
approved these changes
Oct 24, 2023
yanzhudd
reviewed
Oct 24, 2023
Juliehzl
reviewed
Oct 25, 2023
src/containerapp/azext_containerapp/containerapp_env_decorator.py
Outdated
Show resolved
Hide resolved
Juliehzl
approved these changes
Oct 25, 2023
Contributor
Author
|
Hi @yanzhudd Could you help to review this PR? It's ready to be reviewed and merged, thanks. |
yanzhudd
approved these changes
Oct 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az containerapp env create: --enable-workload-profilesaz containerapp compose create: fix containerapp invalid memory resourceChange the value of polling Timeout from 10min to 20min.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.