Skip to content

Vm repair#6864

Merged
zhoxing-ms merged 5 commits intoAzure:mainfrom
qwuae1:vm-repair
Oct 25, 2023
Merged

Vm repair#6864
zhoxing-ms merged 5 commits intoAzure:mainfrom
qwuae1:vm-repair

Conversation

@qwuae1
Copy link
Copy Markdown
Contributor

@qwuae1 qwuae1 commented Oct 17, 2023 •
edited
Loading

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

qwuae1 added 2 commits October 10, 2023 03:24
@qwuae1
Update repair_utils.py
5e60372 
# SUSE Linux Enterprise Server 15 SP3
# SUSE Linux Enterprise Server 12 SP5
remove the SUSE image check
and use the image above
@qwuae1
Update repair_utils.py
af09121
@azure-client-tools-bot-prd
Copy link
Copy Markdown

azure-client-tools-bot-prd bot commented Oct 17, 2023 •
edited
Loading

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd
Copy link
Copy Markdown

azure-client-tools-bot-prd bot commented Oct 17, 2023

Hi @qwuae1,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Oct 17, 2023

Thank you for your contribution! We will review the pull request and get back to you soon.

@qwuae1 qwuae1 closed this Oct 18, 2023
@qwuae1 qwuae1 reopened this Oct 18, 2023
@zhoxing-ms
Copy link
Copy Markdown
Contributor

zhoxing-ms commented Oct 19, 2023

Please take a look at this comment~ #6864 (comment)

@zhoxing-ms
Copy link
Copy Markdown
Contributor

zhoxing-ms commented Oct 19, 2023 •
edited
Loading

@haagha Could you please help review the VM repair related PR?

haagha
haagha approved these changes Oct 23, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@haagha haagha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update version number and version history if you want these changes to be published immediately. I don't think a test is required for this PR. Thanks!

@haagha haagha closed this Oct 23, 2023
@haagha haagha reopened this Oct 23, 2023
@qwuae1
Copy link
Copy Markdown
Contributor Author

qwuae1 commented Oct 24, 2023 •
edited
Loading

@zhoxing-ms
Comments got addressed and approved by Haider.
but seems pr still blocked
Can you take a look and approve it?

@zhoxing-ms zhoxing-ms merged commit 87bb99e into Azure:main Oct 25, 2023
@azclibot
Copy link
Copy Markdown
Collaborator

azclibot commented Oct 25, 2023

[Release] Update index.json for extension [ vm-repair ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=99579&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhoxing-ms zhoxing-ms zhoxing-ms approved these changes

@yanzhudd yanzhudd Awaiting requested review from yanzhudd

+1 more reviewer

@haagha haagha haagha approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@zhoxing-ms zhoxing-ms

Labels

None yet

Projects

None yet

Milestone

October 2023 (2023-11-14)

Development

Successfully merging this pull request may close these issues.

5 participants

@qwuae1 @yonzhan @zhoxing-ms @azclibot @haagha