Skip to content

Planned maintenance - package - 10 - 2023#6806

Merged
kairu-ms merged 8 commits intoAzure:mainfrom
adana-popescu:planned-maintenance-10-2023
Oct 24, 2023
Merged

Planned maintenance - package - 10 - 2023#6806
kairu-ms merged 8 commits intoAzure:mainfrom
adana-popescu:planned-maintenance-10-2023

Conversation

@adana-popescu
Copy link
Copy Markdown
Contributor

@adana-popescu adana-popescu commented Sep 26, 2023

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link
Copy Markdown

azure-client-tools-bot-prd bot commented Sep 26, 2023 •
edited
Loading

❌Azure CLI Extensions Breaking Change Test
⚠️maintenance
rule cmd_name rule_message suggest_message
⚠️ 1001 - CmdAdd maintenance applyupdate create-or-update cmd maintenance applyupdate create-or-update added
⚠️ 1001 - CmdAdd maintenance applyupdate update cmd maintenance applyupdate update added
❌managednetworkfabric
rule cmd_name rule_message suggest_message
❌ 1007 - ParaRemove networkfabric acl create cmd networkfabric acl create removed parameter dynamic_match_conf please add back parameter dynamic_match_conf for cmd networkfabric acl create
❌ 1007 - ParaRemove networkfabric acl create cmd networkfabric acl create removed parameter match_conf please add back parameter match_conf for cmd networkfabric acl create
❌ 1002 - CmdRemove networkfabric acl update cmd networkfabric acl update removed please confirm cmd networkfabric acl update removed
❌ 1002 - CmdRemove networkfabric fabric commit-configuration cmd networkfabric fabric commit-configuration removed please confirm cmd networkfabric fabric commit-configuration removed
❌ 1006 - ParaAdd networkfabric ipcommunity create cmd networkfabric ipcommunity create added parameter ip_community_rules please remove parameter ip_community_rules for cmd networkfabric ipcommunity create
❌ 1007 - ParaRemove networkfabric ipcommunity create cmd networkfabric ipcommunity create removed parameter ip_comm_rules please add back parameter ip_comm_rules for cmd networkfabric ipcommunity create
❌ 1002 - CmdRemove networkfabric ipcommunity update cmd networkfabric ipcommunity update removed please confirm cmd networkfabric ipcommunity update removed
❌ 1006 - ParaAdd networkfabric ipextendedcommunity create cmd networkfabric ipextendedcommunity create added parameter ip_extended_community_rules please remove parameter ip_extended_community_rules for cmd networkfabric ipextendedcommunity create
❌ 1007 - ParaRemove networkfabric ipextendedcommunity create cmd networkfabric ipextendedcommunity create removed parameter ip_ext_comm_rules please add back parameter ip_ext_comm_rules for cmd networkfabric ipextendedcommunity create
❌ 1002 - CmdRemove networkfabric ipextendedcommunity update cmd networkfabric ipextendedcommunity update removed please confirm cmd networkfabric ipextendedcommunity update removed
❌ 1002 - CmdRemove networkfabric ipprefix update cmd networkfabric ipprefix update removed please confirm cmd networkfabric ipprefix update removed
❌ 1002 - CmdRemove networkfabric routepolicy update cmd networkfabric routepolicy update removed please confirm cmd networkfabric routepolicy update removed
❌ 1007 - ParaRemove networkfabric taprule create cmd networkfabric taprule create removed parameter dynamic_match_conf please add back parameter dynamic_match_conf for cmd networkfabric taprule create
❌ 1007 - ParaRemove networkfabric taprule create cmd networkfabric taprule create removed parameter polling_interval please add back parameter polling_interval for cmd networkfabric taprule create
❌ 1010 - ParaPropUpdate networkfabric taprule create cmd networkfabric taprule create update parameter match_configurations: updated property options from ['--match-conf'] to ['--match-configurations'] please change property options from ['--match-configurations'] to ['--match-conf'] for parameter match_configurations of cmd networkfabric taprule create
❌ 1007 - ParaRemove networkfabric taprule update cmd networkfabric taprule update removed parameter dynamic_match_conf please add back parameter dynamic_match_conf for cmd networkfabric taprule update
❌ 1010 - ParaPropUpdate networkfabric taprule update cmd networkfabric taprule update update parameter match_configurations: updated property options from ['--match-conf'] to ['--match-configurations'] please change property options from ['--match-configurations'] to ['--match-conf'] for parameter match_configurations of cmd networkfabric taprule update
⚠️ 1006 - ParaAdd networkfabric acl create cmd networkfabric acl create added parameter dynamic_match_configurations
⚠️ 1006 - ParaAdd networkfabric acl create cmd networkfabric acl create added parameter match_configurations
⚠️ 1006 - ParaAdd networkfabric taprule create cmd networkfabric taprule create added parameter dynamic_match_configurations
⚠️ 1006 - ParaAdd networkfabric taprule create cmd networkfabric taprule create added parameter polling_interval_in_seconds
⚠️ 1006 - ParaAdd networkfabric taprule update cmd networkfabric taprule update added parameter dynamic_match_configurations

@azure-client-tools-bot-prd
Copy link
Copy Markdown

azure-client-tools-bot-prd bot commented Sep 26, 2023

Hi @adana-popescu,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Sep 26, 2023

Thank you for your contribution! We will review the pull request and get back to you soon.

@yonzhan yonzhan requested review from jsntcy and kairu-ms September 26, 2023 08:50
@kairu-ms
Copy link
Copy Markdown
Contributor

kairu-ms commented Oct 17, 2023 •
edited
Loading

@adana-popescu, it seems the name changed between recording tests and rerunning in CI. Please fix it.
image

@adana-popescu
Copy link
Copy Markdown
Contributor Author

adana-popescu commented Oct 20, 2023

@kairu-ms I have solved the issue, thank you for letting me know.

@kairu-ms kairu-ms merged commit c6b4565 into Azure:main Oct 24, 2023
@azclibot
Copy link
Copy Markdown
Collaborator

azclibot commented Oct 24, 2023

[Release] Update index.json for extension [ maintenance ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=99364&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kairu-ms kairu-ms kairu-ms approved these changes

@jsntcy jsntcy Awaiting requested review from jsntcy

Assignees

@kairu-ms kairu-ms

Labels

None yet

Projects

None yet

Milestone

October 2023 (2023-11-14)

Development

Successfully merging this pull request may close these issues.

4 participants

@adana-popescu @yonzhan @kairu-ms @azclibot