Skip to content

Removing validation for classification#6760

Merged
kairu-ms merged 3 commits intoAzure:mainfrom
roramc:main
Sep 15, 2023
Merged

Removing validation for classification#6760
kairu-ms merged 3 commits intoAzure:mainfrom
roramc:main

Conversation

@roramc
Copy link
Copy Markdown
Contributor

@roramc roramc commented Sep 14, 2023


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@roramc roramc requested a review from zhoxing-ms as a code owner September 14, 2023 10:48
@azure-client-tools-bot-prd
Copy link
Copy Markdown

azure-client-tools-bot-prd bot commented Sep 14, 2023

⚠️Azure CLI Extensions Breaking Change Test
⚠️automation
rule cmd_name rule_message suggest_message
⚠️ 1009 - ParaPropRemove automation software-update-configuration create cmd automation software-update-configuration create update parameter included_update_classifications: removed property choices=['Critical', 'Definition', 'FeaturePack', 'Security', 'ServicePack', 'Tools', 'Unclassified', 'UpdateRollup', 'Updates']

@azure-client-tools-bot-prd
Copy link
Copy Markdown

Hi @roramc,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Sep 14, 2023

Thank you for your contribution! We will review the pull request and get back to you soon.

@zhoxing-ms
Copy link
Copy Markdown
Contributor

#6760 (comment) Please take a look at this comment~

@kairu-ms kairu-ms merged commit dfde7ce into Azure:main Sep 15, 2023
@azclibot
Copy link
Copy Markdown
Collaborator

[Release] Update index.json for extension [ automation ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=90655&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants