Skip to content

Update validation for ASM Pluginca feature#6744

Merged
zhoxing-ms merged 6 commits intoAzure:mainfrom
deveshdama:main
Sep 11, 2023
Merged

Update validation for ASM Pluginca feature#6744
zhoxing-ms merged 6 commits intoAzure:mainfrom
deveshdama:main

Conversation

@deveshdama
Copy link
Copy Markdown
Contributor

@deveshdama deveshdama commented Sep 9, 2023

Add validation for keyvault field

az aks mesh enable -g rg-name -n mc-name
--key-vault-id /subscriptions/854c9ddb-fe9e-4aea-8d58-99ed88282881/resourceGroups/rg-test/providers/Microsoft.KeyVault/vaults/test-vault
--ca-cert-object-name ca-cert-name
--ca-key-object-name ca-key-name
--root-cert-object-name root-cert-name
--cert-chain-object-name cert-chain-name

Related command

az aks mesh enable

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link
Copy Markdown

azure-client-tools-bot-prd bot commented Sep 9, 2023 •
edited
Loading

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd
Copy link
Copy Markdown

azure-client-tools-bot-prd bot commented Sep 9, 2023

Hi @deveshdama,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Sep 9, 2023

Thank you for your contribution! We will review the pull request and get back to you soon.

FumingZhang
FumingZhang reviewed Sep 11, 2023
View reviewed changes
src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py
# enable azure service mesh with pluginca
update_cmd = 'aks mesh enable --resource-group={resource_group} --name={name} ' \
'--key-vault-id my-akv-id ' \
'--key-vault-id {akv_resource_id} ' \
Copy link
Copy Markdown
Member

@FumingZhang FumingZhang Sep 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Queued live test to validate the change.

Copy link
Copy Markdown
Member

@FumingZhang FumingZhang Sep 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test passed

FumingZhang
FumingZhang approved these changes Sep 11, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhoxing-ms zhoxing-ms merged commit 803195c into Azure:main Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhoxing-ms zhoxing-ms zhoxing-ms approved these changes

@FumingZhang FumingZhang FumingZhang approved these changes

@andyliuliming andyliuliming Awaiting requested review from andyliuliming andyliuliming is a code owner

@yanzhudd yanzhudd Awaiting requested review from yanzhudd

@yonzhan yonzhan Awaiting requested review from yonzhan

Assignees

@zhoxing-ms zhoxing-ms

@yanzhudd yanzhudd

Labels

AKS Auto-Assign Auto assign by bot

Projects

None yet

Milestone

September 2023 (2023-09-26)

Development

Successfully merging this pull request may close these issues.

5 participants

@deveshdama @yonzhan @zhoxing-ms @FumingZhang @yanzhudd