Make sure the resource created for the Public IP match the name repai…#6737
Make sure the resource created for the Public IP match the name repai…#6737zhoxing-ms merged 3 commits intoAzure:mainfrom
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
|
Hi @jonathanbrenes, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
haagha
left a comment
There was a problem hiding this comment.
Changes look good, If you want this to change to be published you have to update version number and describe the update:
azure-cli-extensions/src/vm-repair/setup.py at jbrenes-fix-publicip · jonathanbrenes/azure-cli-extensions (github.com)
azure-cli-extensions/src/vm-repair/HISTORY.rst at jbrenes-fix-publicip · jonathanbrenes/azure-cli-extensions (github.com)
jonathanbrenes
left a comment
There was a problem hiding this comment.
Version and HISTORY.rst changed as requested
|
[Release] Update index.json for extension [ vm-repair ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=89855&view=results |
Make sure the resource created for the Public IP match the name repair-_PublicIP
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az vm repair
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired) yespython scripts/ci/test_index.py -qlocally? yesAbout Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.