[AKS] az aks update: add new parameter --disable-workload-identity to disable Workload Identity#6706
Conversation
❌Azure CLI Extensions Breaking Change Test
|
|
Hi @jiashun0011, |
|
Hi @jiashun0011, |
|
AKS |
FumingZhang
left a comment
There was a problem hiding this comment.
LGTM, please leave some notes in history.rst
… disable Workload Identity
45819c4 to
99a7aa0
Compare
| disable_cmd = ' '.join([ | ||
| 'aks', 'update', '--resource-group={resource_group}', '--name={name}', | ||
| '--enable-workload-identity', 'False', | ||
| '--disable-workload-identity', |
| c.argument('enable_pod_identity', action='store_true') | ||
| c.argument('enable_pod_identity_with_kubenet', action='store_true') | ||
| c.argument('enable_workload_identity', arg_type=get_three_state_flag(), is_preview=True) | ||
| c.argument('enable_workload_identity', action='store_true', is_preview=True) |
There was a problem hiding this comment.
Modifying parameter types may cause a breaking change, such as if --enable-workload-identity True was used in the automation script, it may no longer work
There was a problem hiding this comment.
Yes, and in our stable cli, we already used enable + diable, though we will remove the preview extension in future, we still want to align it with stable version.
|
@jiashun0011 Please resolve this conflict |
|
#6706 (comment) If you want to release a new extension version for this PR, please also upgrade the version defined in the |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
updated |
|
[Release] Update index.json for extension [ aks-preview ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=90020&view=results |
[AKS] az aks update: add new parameter
--disable-workload-identityto disable Workload IdentityThis checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.