[vm-repair] arm64 support And Bug Fix for telemetry#6649
Merged
zhoxing-ms merged 6 commits intoAzure:mainfrom Sep 1, 2023
Merged
[vm-repair] arm64 support And Bug Fix for telemetry#6649zhoxing-ms merged 6 commits intoAzure:mainfrom
zhoxing-ms merged 6 commits intoAzure:mainfrom
Conversation
Collaborator
|
vm-repair |
️✔️Azure CLI Extensions Breaking Change Test
|
Contributor
|
Could you add some test cases for this PR change? |
Contributor
|
Please add more details (related commands and parameters) to the description. |
Member
Author
|
@zhoxing-ms added a test case. |
Member
Author
|
CI check failure seems unrelated to my changes. |
zhoxing-ms
approved these changes
Sep 1, 2023
Collaborator
|
[Release] Update index.json for extension [ vm-repair ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=87539&view=results |
malachma
reviewed
Sep 6, 2023
Member
malachma
left a comment
There was a problem hiding this comment.
The object/property command.message is populated with information about the fstab action which got executed. This looks to be like a generic message which may confuse people if a different action is used. Is there a condition I overlooked which is responsible for getting the message generated?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
ARM64 VM's support for vm repair creation
Telemetry Fix for repair-and-restore command
Repair VM fix for gen1 VM attaching disk on SCSI controller, preventing nested VM from booting (by Ryan McCallum)
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az vm repair create -g {rg} -n {vm}
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.