Skip to content

Updated NetworkCloud 2023-07-01 latest changes for stable version 1.0.0#6648

Merged
kairu-ms merged 1 commit intoAzure:mainfrom
priyamshet:priyashet/networkCloud2023-07-01stableReleaseUpdate
Aug 17, 2023
Merged

Updated NetworkCloud 2023-07-01 latest changes for stable version 1.0.0#6648
kairu-ms merged 1 commit intoAzure:mainfrom
priyamshet:priyashet/networkCloud2023-07-01stableReleaseUpdate

Conversation

@priyamshet
Copy link
Copy Markdown
Member

@priyamshet priyamshet commented Aug 15, 2023


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Aug 15, 2023

Thank you for your contribution! We will review the pull request and get back to you soon.

@azure-client-tools-bot-prd
Copy link
Copy Markdown

azure-client-tools-bot-prd bot commented Aug 15, 2023

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd
Copy link
Copy Markdown

Hi @priyamshet,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@priyamshet priyamshet marked this pull request as ready for review August 15, 2023 18:47
@priyamshet priyamshet marked this pull request as draft August 15, 2023 19:24
@priyamshet priyamshet force-pushed the priyashet/networkCloud2023-07-01stableReleaseUpdate branch from ce9573e to 0c83ea7 Compare August 15, 2023 19:45
@priyamshet priyamshet marked this pull request as ready for review August 15, 2023 19:58
@priyamshet priyamshet force-pushed the priyashet/networkCloud2023-07-01stableReleaseUpdate branch from 0c83ea7 to 05baf93 Compare August 15, 2023 21:39
@yonzhan yonzhan requested review from jsntcy, kairu-ms and necusjz August 15, 2023 23:13
@priyamshet priyamshet force-pushed the priyashet/networkCloud2023-07-01stableReleaseUpdate branch from 05baf93 to d8c1fcd Compare August 15, 2023 23:20
@kairu-ms
Copy link
Copy Markdown
Contributor

Hi @priyamshet, PR is approved. Is it ready to release?

@priyamshet priyamshet force-pushed the priyashet/networkCloud2023-07-01stableReleaseUpdate branch from d8c1fcd to b15588f Compare August 16, 2023 17:27
@priyamshet
Copy link
Copy Markdown
Member Author

priyamshet commented Aug 16, 2023

@kairu-ms thanks for the review, there was a small change to update the description of a parameter "enabled" and a minor fix for the VirtualMachine console resource. We have pushed the corresponding aaz change in this PR. Azure/aaz#281

Yes the changes are ready to be released.

@priyamshet priyamshet marked this pull request as draft August 16, 2023 19:08
@priyamshet priyamshet marked this pull request as ready for review August 16, 2023 21:11
@kairu-ms kairu-ms merged commit 1fdb9b2 into Azure:main Aug 17, 2023
@azclibot
Copy link
Copy Markdown
Collaborator

[Release] Update index.json for extension [ networkcloud ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=83252&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants