Skip to content

containerapp add three type for enable workload profiles#6647

Merged
zhoxing-ms merged 3 commits intoAzure:mainfrom
Greedygre:xinyu/set_3_type_enable_workload_profiles
Aug 16, 2023
Merged

containerapp add three type for enable workload profiles#6647
zhoxing-ms merged 3 commits intoAzure:mainfrom
Greedygre:xinyu/set_3_type_enable_workload_profiles

Conversation

@Greedygre
Copy link
Copy Markdown
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az containerapp env create

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link
Copy Markdown

azure-client-tools-bot-prd bot commented Aug 15, 2023

❌Azure CLI Extensions Breaking Change Test
❌containerapp
rule cmd_name rule_message suggest_message
1008 - ParaPropAdd containerapp env create cmd containerapp env create update parameter enable_workload_profiles: added property choices=['false', 'true'] please remove property choices=['false', 'true'] for parameter enable_workload_profiles of cmd containerapp env create
⚠️ 1008 - ParaPropAdd containerapp env create cmd containerapp env create update parameter enable_workload_profiles: added property nargs=?

@azure-client-tools-bot-prd
Copy link
Copy Markdown

Hi @Greedygre,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Aug 15, 2023

Thank you for your contribution! We will review the pull request and get back to you soon.

@Greedygre Greedygre marked this pull request as ready for review August 15, 2023 08:27
@Greedygre
Copy link
Copy Markdown
Contributor Author

Hi, @zhoxing-ms
This pr is ready to merge, could you please help to merge? Thanks.

@zhoxing-ms zhoxing-ms merged commit dc27eeb into Azure:main Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Assign Auto assign by bot ContainerApp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants