Skip to content

ManagedNetworkFabric - Updated CLI extension for API version 2023-06-15#6640

Merged
kairu-ms merged 11 commits intoAzure:mainfrom
rahulm-msft:rahul-msft/managednetworkfabric-extension
Aug 22, 2023
Merged

ManagedNetworkFabric - Updated CLI extension for API version 2023-06-15#6640
kairu-ms merged 11 commits intoAzure:mainfrom
rahulm-msft:rahul-msft/managednetworkfabric-extension

Conversation

@rahulm-msft
Copy link
Copy Markdown
Contributor

@rahulm-msft rahulm-msft commented Aug 11, 2023 •
edited
Loading

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az networkfabric -h

Group
    az networkfabric : Manage Azure Network Fabric Management Service API.

Subgroups:
    acl                 : Manage Access Control List Resource.
    controller          : Manage Network Fabric Controller Resource.
    device              : Manage Network Device Resource.
    externalnetwork     : Manage External Network Resource.
    fabric              : Manage Network Fabric Resource.
    interface           : Manage Network Interface Resource.
    internalnetwork     : Manage Internal Network Resource.
    internetgateway     : Manage Internet Gateway Resource.
    internetgatewayrule : Manage Internet Gateway Rule Resource.
    ipcommunity         : Manage Ip Community Resource.
    ipextendedcommunity : Manage Ip Extended Community Resource.
    ipprefix            : Manage Ip Prefix Resource.
    l2domain            : Manage L2 Isolation Domain Resource.
    l3domain            : Manage L3 Isolation Domain Resource.
    nni                 : Manage Network To Network Interconnect Resource.
    rack                : Manage Network Rack Resource.
    routepolicy         : Manage Route Policy Resource.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@rahulm-msft rahulm-msft requested a review from kairu-ms as a code owner August 11, 2023 17:54
@azure-client-tools-bot-prd
Copy link
Copy Markdown

azure-client-tools-bot-prd bot commented Aug 11, 2023 •
edited
Loading

⚠️Azure CLI Extensions Breaking Change Test
⚠️managednetworkfabric
rule cmd_name rule_message suggest_message
⚠️ 1011 - SubgroupAdd networkfabric acl sub group networkfabric acl added
⚠️ 1011 - SubgroupAdd networkfabric neighborgroup sub group networkfabric neighborgroup added
⚠️ 1006 - ParaAdd networkfabric routepolicy create cmd networkfabric routepolicy create added parameter default_action
⚠️ 1011 - SubgroupAdd networkfabric tap sub group networkfabric tap added
⚠️ 1011 - SubgroupAdd networkfabric taprule sub group networkfabric taprule added

@azure-client-tools-bot-prd
Copy link
Copy Markdown

azure-client-tools-bot-prd bot commented Aug 11, 2023

Hi @rahulm-msft,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Aug 11, 2023

Thank you for your contribution! We will review the pull request and get back to you soon.

@yonzhan yonzhan requested a review from necusjz August 11, 2023 22:55
@yonzhan yonzhan requested a review from jsntcy August 11, 2023 22:56
@kairu-ms kairu-ms merged commit 23945bf into Azure:main Aug 22, 2023
@azclibot
Copy link
Copy Markdown
Collaborator

azclibot commented Aug 22, 2023

[Release] Update index.json for extension [ managednetworkfabric ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=84674&view=results

@rahulm-msft rahulm-msft deleted the rahul-msft/managednetworkfabric-extension branch August 22, 2023 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kairu-ms kairu-ms kairu-ms approved these changes

@necusjz necusjz Awaiting requested review from necusjz

@jsntcy jsntcy Awaiting requested review from jsntcy

Assignees

@kairu-ms kairu-ms

Labels

do-not-merge

Projects

None yet

Milestone

August 2023 (2023-09-05)

Development

Successfully merging this pull request may close these issues.

4 participants

@rahulm-msft @yonzhan @azclibot @kairu-ms