Add pluginca parameters for az aks mesh command#6631
Merged
zhoxing-ms merged 7 commits intoAzure:mainfrom Aug 14, 2023
deveshdama:main
Merged
Add pluginca parameters for az aks mesh command#6631zhoxing-ms merged 7 commits intoAzure:mainfrom deveshdama:main
zhoxing-ms merged 7 commits intoAzure:mainfrom
deveshdama:main
Conversation
* initial changes * passing plugin ca params to decorator * Iterative changes * Adding live tests * remove pluginca test from initial setup. pluginca is not valid for new AKS cluster create enable akv addon before asm addon with pluginca as this is a pre-req. fix a typo in test case fix a typo in test case adding the recording file for live test
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| aks mesh enable | cmd aks mesh enable added parameter ca_cert_object_name |
||
| aks mesh enable | cmd aks mesh enable added parameter ca_key_object_name |
||
| aks mesh enable | cmd aks mesh enable added parameter cert_chain_object_name |
||
| aks mesh enable | cmd aks mesh enable added parameter key_vault_id |
||
| aks mesh enable | cmd aks mesh enable added parameter root_cert_object_name |
|
Hi @deveshdama, |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
FumingZhang
reviewed
Aug 11, 2023
FumingZhang
reviewed
Aug 11, 2023
FumingZhang
approved these changes
Aug 11, 2023
Member
FumingZhang
left a comment
There was a problem hiding this comment.
LGTM
Please update HISTORY.rst and leave some notes
FumingZhang
reviewed
Aug 14, 2023
zhoxing-ms
approved these changes
Aug 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add pluginca parameters for az aks mesh command
--key-vault-id akv-id
--ca-cert-object-name ca-cert-name
--ca-key-object-name ca-key-name
--root-cert-object-name root-cert-name
--cert-chain-object-name cert-chain-name
Related command
az aks mesh enableGeneral Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.