You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The changes in the pull request are to address a problem found in the azure cli serial-console extension where an error was being thrown for eastus connections because there wasn't a pair region mapping for westus. The code changes add the eastus to westus region mappings to fix this issue.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az serial-console connect -g MyResourceGroup -n MyVmName
General Guidelines
Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
Have you run python scripts/ci/test_index.py -q locally?
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.
Azure Pipelines successfully started running 1 pipeline(s).
kairu-ms
changed the title
[Serial-Console]: Fix pair mapping region for eastus to westus
[Serial-Console] Fix pair mapping region for eastus to westus
May 5, 2023
@msftvito - when I run the "azdev test serial-console --live" command to record the new test results the command completes successfully for me. I look at the build log where the failure occurs but I don't see why it fails here and not when I locally run the live tests. Can you run the command and see if you get the same results?
Hi @rhkodiak, according to the CI result, it seems the azure-mgmt-resource sdk is not the latest in your Local machine. Please pull the latest change of dev branch of azure-cli repo and run azdev setup again to update the sdks. After that you can record the tests again.
Hi @rhkodiak, according to the CI result, it seems the azure-mgmt-resource sdk is not the latest in your Local machine. Please pull the latest change of dev branch of azure-cli repo and run azdev setup again to update the sdks. After that you can record the tests again.
Hi @kairu-ms, I ran the instructions you provided and everything looks good now so ready for you to review. Thanks for the help!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes in the pull request are to address a problem found in the azure cli serial-console extension where an error was being thrown for eastus connections because there wasn't a pair region mapping for westus. The code changes add the eastus to westus region mappings to fix this issue.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az serial-console connect -g MyResourceGroup -n MyVmName
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.