aks-preview: feature support for web application routing#4872
Merged
zhoxing-ms merged 24 commits intoAzure:mainfrom May 25, 2022
Merged
aks-preview: feature support for web application routing#4872zhoxing-ms merged 24 commits intoAzure:mainfrom
zhoxing-ms merged 24 commits intoAzure:mainfrom
Conversation
…e-resource-id parameter.
…uting --dns-zone-resource-id ..."
Fix the following warnings: E128 continuation line under-indented for visual indent W293 blank line contains whitespace E302 expected 2 blank lines, found 1
Collaborator
|
aks-preview |
FumingZhang
reviewed
May 23, 2022
Change
c.argument('dns-zone-resource-id', options_list=['--dns-zone-resource-id'])
to
c.argument('dns-zone-resource-id')
The options_list=['--dns-zone-resource-id'] just use the default option, so it is not needed to be specified.
…imilary to gitops addon: Run it in "set_up_addon_profiles".
…ebApplicationRouting" Since web application routing's settings are in its own IngressProfile, not addon profile, we don't need to defined this constant, which is used as the name in addon profile.
FumingZhang
reviewed
May 24, 2022
Member
FumingZhang
left a comment
There was a problem hiding this comment.
The PR basically looks good to me. But I've to say there are three different mechanisms to enable an addon which is quite complicated and not all of them are covered by existing test cases.
src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py
Outdated
Show resolved
Hide resolved
src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py
Outdated
Show resolved
Hide resolved
Member
Author
I've made a note of this to add more test cases. Right now update test case can't be added yet because there's a bug on the backend for updating that's fixed last Friday. After that code is rolled out, I'll add the test cases. |
jveski
approved these changes
May 24, 2022
FumingZhang
reviewed
May 25, 2022
src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py
Outdated
Show resolved
Hide resolved
zhoxing-ms
reviewed
May 25, 2022
FumingZhang
reviewed
May 25, 2022
Co-authored-by: FumingZhang <81607949+FumingZhang@users.noreply.github.com>
Co-authored-by: FumingZhang <81607949+FumingZhang@users.noreply.github.com>
…or when addon is not enabled (thus the request isn't valid).
zhoxing-ms
approved these changes
May 25, 2022
….com/yizhang4321/azure-cli-extensions into yizhang4321/AddWebApplicationRouting
…S backend. The bug has been fixed but the release hasn't been rolled out yet. I'll renable the check once the fix has been rolled out.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style aks-previewlocally? (pip install azdevrequired)Yes, I have run it. It showed many warnings, but not related to this PR
python scripts/ci/test_index.py -qlocally?Yes: result:
% python scripts/ci/test_index.py -q
Ran 9 tests in 0.045s
OK (skipped=2)
For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify
src/index.json.