Skip to content

[AKS] Support update kubelet identity#4740

Merged
zhoxing-ms merged 8 commits intoAzure:mainfrom
norshtein:tosi/ki-update
Apr 28, 2022
Merged

[AKS] Support update kubelet identity#4740
zhoxing-ms merged 8 commits intoAzure:mainfrom
norshtein:tosi/ki-update

Conversation

@norshtein
Copy link
Copy Markdown
Member


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@norshtein norshtein changed the title Support update kubelet identity [AKS] Support update kubelet identity Apr 26, 2022
@norshtein norshtein requested a review from kairu-ms as a code owner April 26, 2022 07:44
@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Apr 26, 2022

AKS

@yonzhan yonzhan requested a review from zhoxing-ms April 26, 2022 09:16
@yonzhan yonzhan requested a review from wangzelin007 April 26, 2022 09:16
@yonzhan yonzhan added this to the May 2022 (2022-05-24) milestone Apr 26, 2022
++++++

* Add support for updating kubelet identity. Command is
* `az aks create --cluster-snapshot-id <snapshot-id>`
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure this is the right command?

Copy link
Copy Markdown
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines +9 to +10
* Add support for updating kubelet identity. Command is
* `az aks update --assign-kubelet-identity <kubelelt-identity-resource-id>`
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May I ask what's the difference between kubelet identity and managed identity?

Copy link
Copy Markdown
Member Author

@norshtein norshtein Apr 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kubelet identity is used by kubelet in agent node, its main purpose is authenticating to ACR to pull image from ACR;
--enable-managed-identity or --assign-identity refers to control plane identity, which is used by AKS managed master components such as kube-controller-manager, its main purpose is to authenticating to Azure to manage Azure resource, for example, when kube-controller-manager find it needs to update load balancer, it will authenticate using control plane identity to do the operation.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I know, there is a (managed or user assigned) identity used by the control plane (i.e., managed cluster) and another one (this kubelet identity) used by the nodes (mainly used for authentication when pulling image from acr).

Co-authored-by: Xing Zhou <Zhou.Xing@microsoft.com>
@norshtein
Copy link
Copy Markdown
Member Author

The live test failed because RP change is not rolled out to all regions

@norshtein
Copy link
Copy Markdown
Member Author

Updated live test region to centraluseuap. Previous live test is done in westus2 staging env, prod env westus2 does not have this change yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants