Update periscope deployemnt file.#4630
Merged
zhoxing-ms merged 1 commit intoAzure:mainfrom Apr 11, 2022
Merged
Conversation
peterbom
approved these changes
Apr 5, 2022
Member
Author
|
❤️☕️💡 @FumingZhang and @peterbom - Thanks. This will fix the current broken az-cli |
Collaborator
|
AKS |
Member
|
The failed check AZCLI AKS LIVE TEST V2 - [COMPATIBILITY] should be a known issue unrelated to this PR, I'll open another PR to fix it. |
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
zhoxing-ms
approved these changes
Apr 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the fix, this PR updates the old tag within the
aks-periscope deployment filewhich will cause failures, please see below for the old broken change, + new change which fixes the issue.Thanks,
New version working
Old version causes this error
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json.