Thank you for your contribution azclibot! We will review the pull request and get back to you soon.

appservice-kube

CI has the following issue:

ImportError: cannot import name '_FunctionAppStackRuntimeHelper' from 'azure.cli.command_modules.appservice.custom'

It is due to the introduction of PR #4384 (comment) @StrawnSC Please take a look~

@zhoxing-ms what version of the CLI does the CI use?

This appservice-kube extension update uses features that are set to be released with CLI version 2.34.0 (currently in the dev branch of the CLI). In the extension, I set the min CLI version to 2.34.0 so that users won't run into this incompatibility. Will this have to wait until that version is released?

@zhoxing-ms what version of the CLI does the CI use?

This appservice-kube extension update uses features that are set to be released with CLI version 2.34.0 (currently in the dev branch of the CLI). In the extension, I set the min CLI version to 2.34.0 so that users won't run into this incompatibility. Will this have to wait until that version is released?

@StrawnSC the AppServicePlan-kube extension has an explicit import statement here for sporting file _FunctionAppStackRuntimeHelper - was this removed in core-cli, which means once this releases, this extension will break.

The CI/CD here might be using the latest available dev & hence catching this earlier. We should fix this soon.

@panchagnula the class _FunctionAppStackRuntimeHelper was added recently by my runtime stacks update (not removed): https://github.com/Azure/azure-cli/blob/dev/src/azure-cli/azure/cli/command_modules/appservice/custom.py#L3127

It's not in a released version of the CLI yet though so the CI must be using the prod version of the CLI instead of building from dev

@zhoxing-ms could we rerun the CI on March 1st when CLI version 2.34.0 is released?

could we rerun the CI on March 1st when CLI version 2.34.0 is released?

OK

@panchagnula the class _FunctionAppStackRuntimeHelper was added recently by my runtime stacks update (not removed): https://github.com/Azure/azure-cli/blob/dev/src/azure-cli/azure/cli/command_modules/appservice/custom.py#L3127

It's not in a released version of the CLI yet though so the CI must be using the prod version of the CLI instead of building from dev

Ah! I see so the extension was updated to use this import before the changes to core-cli was released to PROD? that explains the error - we should wait for the dependent changes to release then. In addition running the CI/CD pipeline, can we test the changes as well before we release the new extension?

we should wait for the dependent changes to release then. In addition running the CI/CD pipeline, can we test the changes as well before we release the new extension?

You can use the development environment provided by azdev for testing in advance

@panchagnula I manually tested the changes locally. I can go ahead and start adding some ScenarioTests too

/azp run

could we rerun the CI on March 1st when CLI version 2.34.0 is released?

OK

@zhoxing-ms can you rerun the CI? It looks like I don't have permissions to do so

*edit: never mind, Sisira reran the CI for me

Please resolve the conflicting files

I'm tried to push a fix to the merge conflict here, but I don't have permissions to push to the azclibot/azure-cli-extensions repo

It's a pretty simple merge conflict. Could someone with permissions fix it or give me permissions to push?

Replaced by #4481

Thanks @zhoxing-ms!