[k8s-extension] Release v1.0.4 with SSL secret support for AzureML#4286
Merged
zhoxing-ms merged 181 commits intoAzure:mainfrom Jan 7, 2022
Merged
[k8s-extension] Release v1.0.4 with SSL secret support for AzureML#4286zhoxing-ms merged 181 commits intoAzure:mainfrom
zhoxing-ms merged 181 commits intoAzure:mainfrom
Conversation
[pull] release from Azure:master
…into k8s-extension/public-preview
* Update sdks with updated swagger spec * Update version and history rst * Reorder release history timeline * Fix ExtensionInstanceForCreate for import
…into k8s-extension/public
…es/azure-cli-extensions into k8s-extension/public
* populate configuration protected settings for azureml bump version && add log fetch connection string only if configuration protected settings are set update ssl key * bump the version * reverse changes on version and HISTORY.rst * inferenceLoadBalancerHA Co-authored-by: Yue Yu <yuyu3@microsoft.com>
* Unparallelize tests * Moved location of pipeline file * Remove the parallel invoke expression calls * Add templates to testing
Co-authored-by: Yue Yu <yuyu3@microsoft.com> Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com>
…into k8s-extension/public
* Add one more prompt for amlarc extension update * fix pylint issue * fix pylint issue * fix pylint issue * fix pylint issue Co-authored-by: Youhua Tu <youhuatu@outlook.com> Co-authored-by: Youhua Tu <youhuatu@microsoft.com>
* Update appliance API to latest version for identity * Create a utils file with get parent_api_version * Fix style errors
…into k8s-extension/public
…es/azure-cli-extensions into k8s-extension/public
…into k8s-extension/public
* support sslSecret * fix * fix error message Co-authored-by: Jun Min <mijun@microsoft.com>
…into k8s-extension/public
Collaborator
|
k8s-extension |
wangzelin007
reviewed
Jan 5, 2022
Member
wangzelin007
left a comment
There was a problem hiding this comment.
May I ask you to add some tests for this release?
Contributor
Author
Hi @wangzelin007. We have E2E tests that we run in our fork that are not merged into upstream. We are unable to do unit testing because our extension resource relies on pre-created resources in Azure (i.e. a connectedCluster resource) |
wangzelin007
approved these changes
Jan 6, 2022
zhoxing-ms
approved these changes
Jan 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json.