Skip to content

Azure CLI commands for communication#4206

Merged
kairu-ms merged 24 commits intoAzure:mainfrom
moirf:v-ratann/Communicaton-commands
Jan 7, 2022
Merged

Azure CLI commands for communication#4206
kairu-ms merged 24 commits intoAzure:mainfrom
moirf:v-ratann/Communicaton-commands

Conversation

@ravithanneeru
Copy link
Copy Markdown
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@kairu-ms
Copy link
Copy Markdown
Contributor

@ravithanneeru could you pull the latest code and commit again?

@yonzhan yonzhan added this to the Jan 2022 (2022-02-01) milestone Dec 21, 2021
@moirf
Copy link
Copy Markdown

moirf commented Dec 23, 2021

@ravithanneeru could you pull the latest code and commit again?

@kairu-ms latest code taken and all checks passing now.

Comment on lines +120 to +130
helps['communication identity issue-access-token'] = """
type: command
short-summary: "Issues a new access token with the specified scopes for a given User Identity. If no User Identity is specified, creates a new User Identity as well."
examples:
- name: issue-access-token
text: |-
az communication identity issue-access-token --scope chat
- name: issue-access-token with multiple scopes and userid
text: |-
az communication identity issue-access-token --scope chat voip --userid "8:acs:xxxxxx"
"""
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this command used for? Where will user use the access token?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kairu-ms This command is used for generate an access_token can be used to make call to communication service endpoints. This command help achieve this in azure cli - Quickstart: Create and manage access tokens

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kairu-ms can you please review?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@moirf, If you want to release this extension, you should update the version of the extension and add release history

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kairu-ms version and release history updated.



# pylint: disable=unused-argument
def cf_communication_identity(cli_ctx, kwargs):
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's cli_ctx used for?

@kairu-ms kairu-ms merged commit 72de9b7 into Azure:main Jan 7, 2022
@moirf moirf deleted the v-ratann/Communicaton-commands branch January 8, 2022 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants