Skip to content

{AKS} Add backward compatibility to cli#4047

Merged
zhoxing-ms merged 10 commits intoAzure:mainfrom
FumingZhang:fuming/create-bc
Nov 1, 2021
Merged

{AKS} Add backward compatibility to cli#4047
zhoxing-ms merged 10 commits intoAzure:mainfrom
FumingZhang:fuming/create-bc

Conversation

@FumingZhang
Copy link
Copy Markdown
Member

@FumingZhang FumingZhang commented Nov 1, 2021

This checklist is used to make sure that common guidelines for a pull request are followed.

  • Remove aks browse.
  • Add support for option --edge-zone.
  • Align api server access profile validation with cli.
  • Backward compatibility with old api version.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Nov 1, 2021

AKS

@yonzhan yonzhan added this to the Nov 2021 (2021-12-07) milestone Nov 1, 2021
wangzelin007
wangzelin007 reviewed Nov 1, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@wangzelin007 wangzelin007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FumingZhang
Copy link
Copy Markdown
Member Author

FumingZhang commented Nov 1, 2021

/azp where

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Nov 1, 2021

Azure DevOps orgs getting events for this repository:

@FumingZhang
Copy link
Copy Markdown
Member Author

FumingZhang commented Nov 1, 2021

/azp help

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Nov 1, 2021

Supported commands
  • help:
    • Get descriptions, examples and documentation about supported commands
    • Example: help "command_name"
  • list:
    • List all pipelines for this repository using a comment.
    • Example: "list"
  • run:
    • Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run.
    • Example: "run" or "run pipeline_name, pipeline_name, pipeline_name"
  • where:
    • Report back the Azure DevOps orgs that are related to this repository and org
    • Example: "where"

See additional documentation.

@FumingZhang
Copy link
Copy Markdown
Member Author

FumingZhang commented Nov 1, 2021

/azp list

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Nov 1, 2021

CI/CD Pipelines for this repository:

@FumingZhang FumingZhang marked this pull request as ready for review November 1, 2021 09:32
@zhoxing-ms zhoxing-ms merged commit 14dadfe into Azure:main Nov 1, 2021
@zhoxing-ms
Copy link
Copy Markdown
Contributor

zhoxing-ms commented Nov 1, 2021

Please add descriptions of these changes in history note. If you need to upgrade extension version to release these changes, please modify setup.py at the same time

zhoxing-ms
zhoxing-ms reviewed Nov 1, 2021
View reviewed changes
src/aks-preview/azext_aks_preview/commands.py
with self.command_group('aks', managed_clusters_sdk, client_factory=cf_managed_clusters) as g:
g.custom_command('kollect', 'aks_kollect')
g.custom_command('kanalyze', 'aks_kanalyze')
g.custom_command('browse', 'aks_browse')
Copy link
Copy Markdown
Contributor

@zhoxing-ms zhoxing-ms Nov 1, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FumingZhang If deleting this command will cause breaking change to the user, please mark it as [BREAKING CHANGE] in the history notes

Copy link
Copy Markdown
Member Author

@FumingZhang FumingZhang Nov 2, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @zhoxing-ms, I suppose user should always have azure-cli installed before using aks-preview and if a command is not implemented in azure-cli-extensions, it will fall back to the implementation in azure-cli.

For this case, the implementation of aks browse is basically the same in azure-cli and azure-cli-extensions (actually a little bit more logic in azure-cli), and after removing this command declaration from the extension side, when aks browse is executed, the implementation in azure-cli will be used.

@FumingZhang
Copy link
Copy Markdown
Member Author

FumingZhang commented Nov 2, 2021

Please add descriptions of these changes in history note. If you need to upgrade extension version to release these changes, please modify setup.py at the same time

As I explained above, the changes in this PR should not introduce breaking changes that users can detect. The command aks browse will fall back to the implementation in azure-cli, and the new option --edge-zone introduced to aks create is in preview and user may not use it.

@FumingZhang FumingZhang deleted the fuming/create-bc branch November 4, 2021 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhoxing-ms zhoxing-ms zhoxing-ms approved these changes

@wangzelin007 wangzelin007 wangzelin007 left review comments

@andyliuliming andyliuliming andyliuliming approved these changes

Assignees

@zhoxing-ms zhoxing-ms

Labels

None yet

Projects

None yet

Milestone

Nov 2021 (2021-12-07)

Development

Successfully merging this pull request may close these issues.

5 participants

@FumingZhang @yonzhan @zhoxing-ms @andyliuliming @wangzelin007