[Diskpool] az disk-pool: Update version to stable swagger, add commands az disk-pool list-zones, az disk-pool redeploy#4011
Merged
calvinhzy merged 9 commits intoAzure:mainfrom Oct 25, 2021
Conversation
Collaborator
|
Diskpool |
az disk-pool: Update version to stable swagger, add commands az disk-pool list-zones, az disk-pool redeployaz disk-pool: Update version to stable swagger, add commands az disk-pool list-zones, az disk-pool redeploy
evelyn-ys
reviewed
Oct 22, 2021
Comment on lines
+171
to
+174
| helps['disk-pool'] = """ | ||
| type: group | ||
| short-summary: Manage disk pool zone with diskpool | ||
| """ |
Member
There was a problem hiding this comment.
Seems duplicated with Line15. I know it's generated, maybe should create an issue for code gen...
evelyn-ys
reviewed
Oct 22, 2021
Member
evelyn-ys
left a comment
There was a problem hiding this comment.
LGTM in general. One question, I thought they want to GA diskpool, should we keep experimental tag for the whole module?
evelyn-ys
approved these changes
Oct 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Azure/azure-cli#19470, update version to stable swagger.
Add
az disk-pool list-zonesAdd
az disk-pool redeployTo test run:
az disk-pool list-zones -l {region}az disk-pool redeploy --name {diskPoolName} --resource-group {rg}This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json.