Skip to content

{AKS} Refactor 5th part of the create sub-command in aks-preview module#4002

Merged
zhoxing-ms merged 10 commits intoAzure:mainfrom
FumingZhang:fuming/decorator-create-5
Oct 26, 2021
Merged

{AKS} Refactor 5th part of the create sub-command in aks-preview module#4002
zhoxing-ms merged 10 commits intoAzure:mainfrom
FumingZhang:fuming/decorator-create-5

Conversation

@FumingZhang
Copy link
Copy Markdown
Member

@FumingZhang FumingZhang commented Oct 21, 2021


This checklist is used to make sure that common guidelines for a pull request are followed.

  • Refactor addon profiles

Unit Test Coverage:

  • "covered_lines": 294,
  • "num_statements": 320,
  • "percent_covered": 91.875,
  • "missing_lines": 26,
  • "excluded_lines": 0

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Oct 21, 2021

AKS

@yonzhan yonzhan added this to the Nov 2021 (2021-12-07) milestone Oct 21, 2021
@FumingZhang FumingZhang marked this pull request as ready for review October 26, 2021 04:46
@zhoxing-ms zhoxing-ms merged commit 98e777d into Azure:main Oct 26, 2021
@FumingZhang FumingZhang deleted the fuming/decorator-create-5 branch October 26, 2021 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants