Conversation
|
k8s |
|
|
||
| with self.command_group('connectedk8s', connectedk8s_sdk_prev, client_factory=cf_connected_cluster_prev_2021_04_01) as g: | ||
| g.custom_command('proxy', 'client_side_proxy_wrapper', is_preview=True) | ||
| pass |
There was a problem hiding this comment.
we dont require it now, but kept it so that it is easier to add preview commands in future. it wont affect the functionality since we have a pass statement.
| # -------------------------------------------------------------------------- | ||
|
|
||
| VERSION = "1.0.0" | ||
| VERSION = "1.0.0b1" |
There was a problem hiding this comment.
Why is this version looking like this ?. Compared to the before one ?.
There was a problem hiding this comment.
we haven't made this change. track-2 sdk team made this change.
| CC_Provider_Namespace_Not_Registered_Fault_Type = "Connected Cluster Provider MS.K8 namespace not registered" | ||
| Default_Namespace_Does_Not_Exist_Fault_Type = "The default namespace defined in the kubeconfig doesn't exist on the kubernetes cluster." | ||
| CLIENT_PROXY_VERSION = '1.1.0' | ||
| CLIENT_PROXY_VERSION = '1.3.017131' |
There was a problem hiding this comment.
We would also need to update the HISTORY.rst & setup.py file
There was a problem hiding this comment.
thanks for pointing out. I have made the change.
|
Not sure what got finally decided but. Please close on if we are going to use CDN for downloading the CSP binary. |
src/connectedk8s/HISTORY.rst
Outdated
|
|
||
| Release History | ||
| =============== | ||
| 1.1.11 |
There was a problem hiding this comment.
This needs to change to 1.1.12 as we recently released the HELM client fix with 1.1.11
There was a problem hiding this comment.
Please merge with latest main branch
There was a problem hiding this comment.
merged latest main.
| # Fetching hybrid connection details from Userrp | ||
| try: | ||
| list_prop = ListClusterUserCredentialsProperties( | ||
| list_prop = ListClusterUserCredentialProperties( |
There was a problem hiding this comment.
I think we also decided in the last scrum to move CSP bits also to Azure CDN endpoint instead of the storage blob endpoint.
Also, the manifest rollout in FF will complete on monday night. We should not release before tuesday.
There was a problem hiding this comment.
made changes to use cdn endpoint for csp
| cloud = send_cloud_telemetry(cmd) | ||
| if cloud == consts.Azure_USGovCloudName: | ||
| telemetry.set_debug_info('User tried proxy command in fairfax') | ||
| raise ClientRequestError(f'Cluster Connect feature is not yet available in {consts.Azure_USGovCloudName}') |
There was a problem hiding this comment.
if we are raising an exception, we should collect exception telemetry as well. Define a fault type for this error
There was a problem hiding this comment.
added a telemetry exception as you asked.
| CC_Provider_Namespace_Not_Registered_Fault_Type = "Connected Cluster Provider MS.K8 namespace not registered" | ||
| Default_Namespace_Does_Not_Exist_Fault_Type = "The default namespace defined in the kubeconfig doesn't exist on the kubernetes cluster." | ||
| CLIENT_PROXY_VERSION = '1.1.0' | ||
| ClusterConnect_Not_Present_Fault_Type = "Cluster connect feature not present in the chosen cloud." |
There was a problem hiding this comment.
pls change "Cluster connect feature not present in the chosen cloud." to "cluster-connect-feature-unavailable"
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json.