Add support to format log streaming of structured JSON output#3408
Merged
Juliehzl merged 7 commits intoAzure:masterfrom May 26, 2021
Merged
Add support to format log streaming of structured JSON output#3408Juliehzl merged 7 commits intoAzure:masterfrom
Juliehzl merged 7 commits intoAzure:masterfrom
Conversation
Collaborator
|
spring cloud |
ShichaoQiu
approved these changes
May 21, 2021
zhoxing-ms
reviewed
May 25, 2021
|
|
||
| def build_log_shortener(length): | ||
| if length <= 0: | ||
| raise CLIError('Logger length in `logger{length}` should be positive') |
Contributor
There was a problem hiding this comment.
Please use the specific error type from azure.cli.core.azclierror instead of CLIError，such as InvalidArgumentValueError
zhoxing-ms
approved these changes
May 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)For the newly added code only.
python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json.