Skip to content

Add support for user agent string in calls to AQ via CLI#3398

Merged
ricardo-espinoza merged 5 commits intoAzure:masterfrom
ricardo-espinoza:user-agent
May 25, 2021
Merged

Add support for user agent string in calls to AQ via CLI#3398
ricardo-espinoza merged 5 commits intoAzure:masterfrom
ricardo-espinoza:user-agent

Conversation

@ricardo-espinoza
Copy link
Copy Markdown
Contributor

As part of this change we are:

  • Defining a user-agent-like string to represent the client used to submit jobs via the CLI.
  • Append this to the user agent of the Control Plane and Data Plane clients.
  • Set this as an environment variable for child processes to read it, as in the case of invoked standalone executables.

@ricardo-espinoza ricardo-espinoza requested a review from qwordy May 19, 2021 07:35
@ricardo-espinoza ricardo-espinoza marked this pull request as draft May 19, 2021 07:37
@yonzhan yonzhan requested review from Juliehzl and zhoxing-ms May 19, 2021 09:17
@yonzhan yonzhan added this to the S187 milestone May 19, 2021
@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented May 19, 2021

quantum

@zhoxing-ms zhoxing-ms modified the milestones: S187, S188 May 20, 2021
@ricardo-espinoza ricardo-espinoza marked this pull request as ready for review May 20, 2021 16:25
@ricardo-espinoza ricardo-espinoza added the Quantum az quantum label May 21, 2021
# This is the version reported by the CLI to the service when submitting requests.
# This should be in sync with the extension version in 'setup.py', unless we need to
# submit using a different version.
CLI_REPORTED_VERSION = "0.5.0"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use one variable? VERSION is also defined in setup.py.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree we should consolidate, for now, this is a way to have the version in development in master reporting a certain value without triggering the release to happen.

@ricardo-espinoza ricardo-espinoza merged commit 1a10660 into Azure:master May 25, 2021
@ricardo-espinoza ricardo-espinoza deleted the user-agent branch May 25, 2021 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Quantum az quantum

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants