[AKS] Fix addon's permission issue after updating to MSI cluster#2680
Merged
arrownj merged 6 commits intoAzure:masterfrom Nov 24, 2020
Merged
Conversation
|
If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR: |
Collaborator
|
AKS |
arrownj
reviewed
Nov 19, 2020
|
|
||
| def _is_msi_cluster(managed_cluster): | ||
| return (managed_cluster and managed_cluster.identity and | ||
| (managed_cluster.identity.type.casefold() == "systemassigned" or managed_cluster.identity.type.casefold() == "userassigned")) |
Contributor
There was a problem hiding this comment.
Can managed_cluster.identity.type be None ?
Member
Author
There was a problem hiding this comment.
Yes, it can be 'None', when it is set to 'None', the cluster is not an MSI cluster so this function should return false.
Contributor
There was a problem hiding this comment.
The code will raise exception if managed_cluster.identity.type is None, right ?
arrownj
approved these changes
Nov 24, 2020
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For clusters updating from SPN cluster to MSI cluster, if the cluster is using addons before updating, when updating finishes, each addon will get a dedicated user assigned identity. Some permission is needed on the user assigned identity to make the addon correctly running. However, currently the permission is not grant, so this PR adds extracts a function
_put_managed_cluster_ensuring_permissionfrom creating path and execute it in updating path to ensure permission.This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json.