[AKS] Support updating from SPN cluster to MSI cluster#2571
[AKS] Support updating from SPN cluster to MSI cluster#2571arrownj merged 6 commits intoAzure:masterfrom
Conversation
|
If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR: |
|
The job "Verify Extensions Index" failed with error: The extension the error referencing to is relevant to Anything I can do to fix the CI error? |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
arrownj
left a comment
There was a problem hiding this comment.
Hi @norshtein , could you please also help add tests for these new parameters ?
|
Hi @arrownj , could you add a "Do-Not-Merge" label for this PR? AKS have a server-side behavior change on this feature which will take effect in next week. I will add a recording after the server side change take effect. |
|
Hi @arrownj , I've added recording for this change and this PR is ready to be merged. Could you please help merge the PR? By the way, I found in the recording file, the |
Hi @norshtein , actually we can add some custom replacer while initializing a |
|
@arrownj thanks for the explanation, it helps! |
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json.