Merged
Conversation
* NFSAAS-2898 Update to R4.5 RP standard * NFSAAS-2897 update to R4.5 RP standard
* NFSAAS-2898 Update to R4.5 RP standard * NFSAAS-2897 update to R4.5 RP standard * NFSAAS-2897 update to R4.5 RP standard
* NFSAAS-2898 Update to R4.5 RP standard * NFSAAS-2897 update to R4.5 RP standard * NFSAAS-2897 update to R4.5 RP standard
tjprescott
suggested changes
Jul 16, 2019
Member
tjprescott
left a comment
There was a problem hiding this comment.
LGTM. One comment on history entry wording.
tjprescott
reviewed
Jul 16, 2019
src/azure-cli/HISTORY.rst
Outdated
|
|
||
| **NetAppFiles** | ||
|
|
||
| * Update for R4.5 version of the RP and API version 2019-06-01 including provision of protocol types. |
Member
There was a problem hiding this comment.
This should be laser-focused on customer-facing changes:
netappfiles create/update: Added new argument--protocol-types.
Contributor
Author
There was a problem hiding this comment.
Updated. I hope acceptable.
* NFSAAS-2898 Update to R4.5 RP standard * NFSAAS-2897 update to R4.5 RP standard * NFSAAS-2897 update to R4.5 RP standard
tjprescott
reviewed
Jul 16, 2019
src/azure-cli/HISTORY.rst
Outdated
|
|
||
| **NetAppFiles** | ||
|
|
||
| * Update for RP R4.5/API version 2019-06-01 : for create/update volume, added new argument --protocol-types |
Member
There was a problem hiding this comment.
"Update for RP R4.5/API version 2019-06-01 :" This is all still extraneous to customers. The format I gave you is quite literally what the standard release notes would look like for this.
tjprescott
approved these changes
Jul 17, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SDK version 0.5.0
API version 2019-06-01
Added protocol type as new command parameter
NFSAAS-2898 Update to R4.5 RP standard
NFSAAS-2897 update to R4.5 RP standard
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).
I adhere to the Command Guidelines.