Add --no-wait support to various commands#6684
Merged
tjprescott merged 3 commits intoAzure:devfrom Jun 29, 2018
tjprescott:AddNoWait
Merged
Add --no-wait support to various commands#6684tjprescott merged 3 commits intoAzure:devfrom tjprescott:AddNoWait
--no-wait support to various commands#6684tjprescott merged 3 commits intoAzure:devfrom
tjprescott:AddNoWait
Conversation
23 tasks
Codecov Report
@@ Coverage Diff @@
## dev #6684 +/- ##
===================================
Coverage 0% 0%
===================================
Files 11 11
Lines 145 145
Branches 11 11
===================================
Misses 145 145Continue to review full report at Codecov.
|
yugangw-msft
approved these changes
Jun 29, 2018
Contributor
yugangw-msft
left a comment
There was a problem hiding this comment.
One question, the rest LGTM
| g.command('list', 'list_at_subscription_scope', table_transformer=transform_deployments_list, min_api='2018-05-01') | ||
| g.command('show', 'get_at_subscription_scope', exception_handler=empty_on_404) | ||
| g.command('delete', 'delete_at_subscription_scope') | ||
| g.command('delete', 'delete_at_subscription_scope', supports_no_wait=True) |
Contributor
There was a problem hiding this comment.
do we need a wait command here?
Member
Author
There was a problem hiding this comment.
Ah, thanks for the catch. Yes, I'll add it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
--no-waitsupport to various VM and VMSS extension, NIC and Deployment commands. Adds somewaitcommands where not previously supported (except VMSS extension, which did not work with generic wait).This checklist is used to make sure that common guidelines for a pull request are followed.
The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).
I adhere to the Command Guidelines.