Preview extension notation & Simple default view for extension list-a…#5882
Preview extension notation & Simple default view for extension list-a…#5882derekbekoe merged 4 commits intoAzure:devfrom
Conversation
|
View a preview at https://prompt.ws/r/Azure/azure-cli/5882 |
|
Some screenshots:
|
|
I'll let Troy and Willie comment on the code itself, but from the screenshot my only feedback is it might make sense to put the Preview and Installed columns to the left of summary (closer to the name) because there can be a lot of whitespace in the summary and it can be tricky to follow across the row to see which extension that random "True" floating in space refers to. |
…vailable - Show message for extensions marked as preview on -h
2b1e86c to
b04089d
Compare
| 'preview': latest['metadata'].get(EXT_METADATA_ISPREVIEW, False), | ||
| 'installed': installed | ||
| }) | ||
| return results |
There was a problem hiding this comment.
Do we have a test for this?
There was a problem hiding this comment.
I do have some tests but not for these changes...
I will take a look at adding tests... 👍
|
@williexu can you take another look? |
williexu
left a comment
There was a problem hiding this comment.
Added testing looks good
Preview extension notation & Simple default view for extension list-available
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).
I adhere to the Command Guidelines.