Skip to content

Touch up pylintrc#3806

Merged
troydai merged 3 commits intoAzure:masterfrom
brettcannon:touch-up-pylint
Jun 21, 2017
Merged

Touch up pylintrc#3806
troydai merged 3 commits intoAzure:masterfrom
brettcannon:touch-up-pylint

Conversation

@brettcannon
Copy link
Copy Markdown
Member

@brettcannon brettcannon commented Jun 21, 2017

This PR does two things. One, it switches from pylint's cryptic codes for checkers to their short names which are much easier to reason about.

Two, I added naming hints (which are off by default due to invalid-name being disabled). At PyCon US 2017 I talked with @troydai about adding a few things to this pylintrc to help promote its use within Microsoft and this change is (currently) it.

@brettcannon brettcannon requested a review from troydai June 21, 2017 20:51
@msftclas
Copy link
Copy Markdown

msftclas commented Jun 21, 2017

@brettcannon,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@codecov-io
Copy link
Copy Markdown

codecov-io commented Jun 21, 2017

Codecov Report

Merging #3806 into master will increase coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3806      +/-   ##
==========================================
+ Coverage   70.75%   70.91%   +0.16%     
==========================================
  Files         424      424              
  Lines       26895    26895              
  Branches     4094     4094              
==========================================
+ Hits        19029    19073      +44     
+ Misses       6621     6578      -43     
+ Partials     1245     1244       -1
Impacted Files Coverage Δ
src/azure-cli-core/azure/cli/core/prompting.py 19.27% <0%> (ø) ⬆️
...ice/azure/cli/command_modules/appservice/custom.py 73.46% <0%> (+0.24%) ⬆️
...zure-cli-vm/azure/cli/command_modules/vm/custom.py 77.01% <0%> (+0.31%) ⬆️
...ource/azure/cli/command_modules/resource/custom.py 62.41% <0%> (+0.33%) ⬆️
...cli-vm/azure/cli/command_modules/vm/_validators.py 75.59% <0%> (+0.33%) ⬆️
...azure-cli-core/azure/cli/core/commands/__init__.py 69.79% <0%> (+0.44%) ⬆️
.../azure/cli/command_modules/vm/_template_builder.py 85.78% <0%> (+0.49%) ⬆️
...zure-cli-sf/azure/cli/command_modules/sf/custom.py 40.53% <0%> (+0.72%) ⬆️
...re-cli-acr/azure/cli/command_modules/acr/_utils.py 82.82% <0%> (+1.01%) ⬆️
...ure-cli-testsdk/azure/cli/testsdk/vcr_test_base.py 70.08% <0%> (+1.17%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 460a9f4...2fa2bb7. Read the comment docs.

troydai
troydai approved these changes Jun 21, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@troydai troydai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Approved!

@troydai troydai merged commit 2834139 into Azure:master Jun 21, 2017
@brettcannon brettcannon deleted the touch-up-pylint branch June 21, 2017 22:52
@brettcannon
Copy link
Copy Markdown
Member Author

brettcannon commented Jun 21, 2017

Thanks for being willing to host the file!

@bebound bebound mentioned this pull request Jun 15, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@troydai troydai troydai approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla-not-required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@brettcannon @msftclas @codecov-io @troydai @haroldrandom