Add wait/no-wait support to "az disk" commands.#3390
Merged
tjprescott merged 1 commit intoAzure:masterfrom May 19, 2017
tjprescott:WaitNoWaitDiskCommands
Merged
Add wait/no-wait support to "az disk" commands.#3390tjprescott merged 1 commit intoAzure:masterfrom tjprescott:WaitNoWaitDiskCommands
tjprescott merged 1 commit intoAzure:masterfrom
tjprescott:WaitNoWaitDiskCommands
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3390 +/- ##
=========================================
- Coverage 70.7% 70.7% -0.01%
=========================================
Files 393 393
Lines 25472 25474 +2
Branches 3884 3884
=========================================
+ Hits 18010 18011 +1
- Misses 6319 6320 +1
Partials 1143 1143
Continue to review full report at Codecov.
|
23 tasks
Contributor
|
LGTM. Let @johanste provides the query to verify we don't have many users using the |
Member
Author
|
@yugangw-msft after looking at the usage statistics, are you comfortable with the breaking change or should be hold off on adding the prompt? |
yugangw-msft
approved these changes
May 19, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2215. Partial addresses #1528.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Command Guidelines
(see Authoring Command Modules)