Change Pylint rules project-wise#3254
Merged
troydai merged 2 commits intoAzure:masterfrom May 8, 2017
troydai:updata.style
Merged
Change Pylint rules project-wise#3254troydai merged 2 commits intoAzure:masterfrom troydai:updata.style
troydai merged 2 commits intoAzure:masterfrom
troydai:updata.style
Conversation
1. Disable too-many-arguments pylint error. Due to the nature of the project many methods' arguments set directly reflects the command options. As a result, there is no way to reduce the arguments set size. The too-many-arguments disable statement is widely used to the extend that essentially the rule doesn't matter anymore. I'll disable the rule globally. 2. Extend the max length to 120 from 100, which is the default pylint value. The 120 characters lenght is the default github review page's line limitation.
tjprescott
approved these changes
May 8, 2017
Codecov Report
@@ Coverage Diff @@
## master #3254 +/- ##
=======================================
Coverage 70.27% 70.27%
=======================================
Files 391 391
Lines 25068 25068
Branches 3811 3811
=======================================
Hits 17617 17617
Misses 6342 6342
Partials 1109 1109
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disable too-many-arguments pylint error. Due to the nature of the
project many methods' arguments set directly reflects the command
options. As a result, there is no way to reduce the arguments set size.
The too-many-arguments disable statement is widely used to the extend
that essentially the rule doesn't matter anymore. I'll disable the rule
globally.
Extend the max length to 120 from 100, which is the default pylint
value. The 120 characters lenght is the default github review page's
line limitation.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Command Guidelines
(see Authoring Command Modules)