[RDBMS] Add Test Scenarios#3240
Conversation
|
@Suna-MS, |
|
These have been run live successfully against the staging environment. This PR will be updated with the test recordings once the production environment is live. |
Codecov Report
@@ Coverage Diff @@
## master #3240 +/- ##
==========================================
+ Coverage 70.44% 70.68% +0.23%
==========================================
Files 391 391
Lines 25130 25130
Branches 3815 3815
==========================================
+ Hits 17702 17762 +60
+ Misses 6312 6243 -69
- Partials 1116 1125 +9
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
All cap for constant: http://legacy.python.org/dev/peps/pep-0008/#constants
There was a problem hiding this comment.
Will resolve in the commit
There was a problem hiding this comment.
If deleting the resource group will delete the server, make skip_delete to be True actually saves time during live test.
There was a problem hiding this comment.
engine is a generic name, it is recommended to be a more specific name. for example, database_engine
There was a problem hiding this comment.
Use addCleanup instead to make sure the file is deleted even if the assertion fails. https://docs.python.org/2/library/unittest.html#unittest.TestCase.addCleanup
There was a problem hiding this comment.
I just disable the too-many-arguments rule project-wise. So you don't need this anymore.
|
Taking a second look. |
There was a problem hiding this comment.
I may have missed something obvious but template has one parameter but 2 params are passed to template.format(...).
There was a problem hiding this comment.
Confirmed that dict.get will not throw KeyError exception so removed the statement.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Command Guidelines
(see Authoring Command Modules)